Proposed updates to support required and optional enumerations. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
reviewed
Oct 7, 2021
Comment on lines
+24
to
31
| message Enum { | ||
| oneof enum_kind { | ||
| string specified = 1; | ||
| Empty unspecified = 2; | ||
| } | ||
|
|
||
| message Empty {} | ||
| } |
There was a problem hiding this comment.
Suggested change
| message Enum { | |
| oneof enum_kind { | |
| string specified = 1; | |
| Empty unspecified = 2; | |
| } | |
| message Empty {} | |
| } | |
| message Enum { | |
| optional string value = 1; | |
| } |
Maybe I'm misunderstanding protobof?
There was a problem hiding this comment.
You could do this but it makes thing more implicit. The way I've done it makes it clearer (albeit slightly larger on the wire). Optional is implicit in pb3 so doesn't have to be stated. The union also allows us to introduce more than two options later.
The other nice thing is that the "enum_kind" becomes something to switch off of in several languages.
Co-authored-by: Weston Pace <weston.pace@gmail.com>
d0627e8
to
71d3488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.