[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_tests: Escape dots in regex strings #595

Merged
merged 2 commits into from
Mar 27, 2019
Merged

db_tests: Escape dots in regex strings #595

merged 2 commits into from
Mar 27, 2019

Conversation

boghicieusebiu
Copy link
Contributor

No description provided.

@sullo
Copy link
Owner
sullo commented Mar 27, 2019

What's the basis for this change? The one on line 1253 looks like a mistake, but since the other fields are regex matched if we want to match a literal dot we need to escape it.

@boghicieusebiu
Copy link
Contributor Author

By looking at the majority of lines in db_tests I concluded that "Match 1", "Match 1 or", ..., "Fail 2" fields are regex matched strings and I found some tests have dot character not escaped where there should be literal dot.

@sullo
Copy link
Owner
sullo commented Mar 27, 2019

Thanks I looked closer and fixed my brain, I thought you were removing \. sequences from the regex matches. This is a helpful PR, thank you.

@sullo sullo merged commit 9736097 into sullo:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants