[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for Docker container usage #591

Merged
merged 3 commits into from
Mar 28, 2019
Merged

Add instructions for Docker container usage #591

merged 3 commits into from
Mar 28, 2019

Conversation

NicolasCARPi
Copy link
Contributor

Docker related documentation was missing.

Docker related documentation was missing.
@NicolasCARPi
Copy link
Contributor Author

@sullo Hello, can you have a look at this PR please :)

@sullo
Copy link
Owner
sullo commented Mar 27, 2019

I rarely use Docker so I'm not fully qualified. @tautology0 or @mostafahussein would be better suited (I think) if they can.

@mostafahussein
Copy link
Contributor
mostafahussein commented Mar 27, 2019

This is looks good to me, Can we just make it Run as a Docker container: instead ?

Also we can replace this # from the nikto directory with the following:

git clone https://github.com/sullo/nikto.git
cd nikto

@NicolasCARPi
Copy link
Contributor Author

@mostafahussein Good remarks :) I've pushed another commit addressing them.

@mostafahussein
Copy link
Contributor
mostafahussein commented Mar 27, 2019

@NicolasCARPi Great!, I would like to suggest another example in case someone wanted to save the reports on the host.
So basically we need to mount a volume and then specify the path on the host and inside the container so we can have a copy of reports when the scan is done
for example:

-v /path/to/reports/on/host:/path/to/reports/inside/container

You can get more details about reports in nikto through this: https://cirt.net/nikto2-docs/reports.html.

@sullo
Copy link
Owner
sullo commented Mar 27, 2019

I will accept the PR when you two are happy 💯

This looks good so far, if we can get the last commented change in... that it for now?

@NicolasCARPi
Copy link
Contributor Author
NicolasCARPi commented Mar 27, 2019

@mostafahussein I have added more examples of usage.

I chose to bind the volume to /tmp inside the container, because the default export dir is also the one with the program and mounting it would break things. /tmp is empty so it's a good fit for this purpose.

Note 1: nikto is executed as root in the container so the resulting exported file is owned by the root user of the host system.

Note 2: it seems the json export is broken, because the json is invalid, but that's for another issue :)

EDIT: I see that the whole file is changed, this is because my system automatically fixed the line endings of the file (remove CRLF line terminators), which I think is a good thing. I might also make another PR to remove some tabs that are present in some lines in the code.

EDIT2: oh in fact there is a .editorconfig in the repo, that's why my editor changed it :] (two weeks ago I didn't have the editorconfig plugin in my vimrc).

@sullo
Copy link
Owner
sullo commented Mar 28, 2019

Ok so we good here for now? With some additional issues to open:

  • JSON Export Invalid
  • Nikto runs as root in Docker

@mostafahussein
Copy link
Contributor
mostafahussein commented Mar 28, 2019

@sullo Yes and I am working on the user issue and some other modifications, one of them related to the reports file permissions that @NicolasCARPi mentioned and I think the PR will be ready by tomorrow. If you are going to open an issue for the user part don't forget to assign it to me, if not then i will send the PR tomorrow after testing the modifications

@sullo sullo merged commit 4a97908 into sullo:master Mar 28, 2019
@NicolasCARPi NicolasCARPi deleted the patch-1 branch March 28, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants