[go: nahoru, domu]

Skip to content

Commit

Permalink
Update CONTRIBUTING.md (flutter#2292)
Browse files Browse the repository at this point in the history
Removes obsolete recommendations about removing mockito (which is now used in testing federated plugins, see firebase/flutterfire#1472).
  • Loading branch information
collinjackson authored and Park Sung Min committed Dec 17, 2019
1 parent 84426c8 commit da06499
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,6 @@ Plugins tests are run automatically on contributions using Cirrus CI. However, d
cost constraints, pull requests from non-committers may not run all the tests
automatically.

The plugins team prefers that unit tests are written using `setMockMethodCallHandler`
rather than using mockito to mock out `MethodChannel`. For a list of the plugins that
are still using the mockito testing style and need to be converted, see
[issue 34284](https://github.com/flutter/flutter/issues/34284). If you are contributing
tests to an existing plugin that uses mockito `MethodChannel`, consider converting
them to use `setMockMethodCallHandler` instead.

Once you've gotten an LGTM from a project maintainer and once your PR has received
the green light from all our automated testing, wait for one the package maintainers
to merge the pull request and `pub submit` any affected packages.
Expand Down

0 comments on commit da06499

Please sign in to comment.