[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added posthog_trace #3863

Merged
merged 5 commits into from
May 22, 2024
Merged

added posthog_trace #3863

merged 5 commits into from
May 22, 2024

Conversation

MartinYe1234
Copy link
Collaborator

added posthog_trace

@vercel Vercel
Copy link
vercel bot commented May 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sweep-chat 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 22, 2024 0:53am
sweep-chat-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 0:53am
sweep-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 0:53am

@sweep-nightly Sweep Nightly
Copy link
Contributor
sweep-nightly bot commented May 22, 2024 •
edited
Loading

Sweep: PR Review

Authors of pull request: @MartinYe1234

sweepai/chat/api.py

Updated the make_serializable function to ensure only stringified values are truncated, preserving the integrity of other data types.

Potential Issues

Sweep isn't 100% sure if the following are issues or not but they may be worth taking a look at.

  • The change from new_dictionary[arg] = json.dumps(value) to _ = json.dumps(value) followed by new_dictionary[arg] = value may introduce a bug if value is not JSON serializable, as it will not be caught by the TypeError and will result in an unhandled exception.

    • sweep/sweepai/chat/api.py

    Lines 35 to 36 in 592935f

    _ = json.dumps(value)
    new_dictionary[arg] = value

    View Diff

sweepai/cli.py

Reordered the username argument in the on_ticket function call to align with the function's parameter definition.

sweepai/core/review_utils.py

Added a seed parameter to various methods and functions to ensure reproducibility and consistency in the review process, and enhanced the issue verification step to improve accuracy.

sweepai/handlers/on_comment.py

Added the posthog_trace decorator to the on_comment function for enhanced tracing and monitoring.

sweepai/handlers/on_jira_ticket.py

Reordered the username parameter in the on_ticket function call within the handle_jira_ticket function.

sweepai/handlers/on_ticket.py

Added posthog_trace decorator to the on_ticket function and reordered the username parameter.

tests/rerun_comment_direct.py

Reordered the username parameter in the on_comment function calls within the pull_request_url function.

@MartinYe1234 MartinYe1234 merged commit 943ca73 into main May 22, 2024
7 checks passed
@MartinYe1234 MartinYe1234 deleted the feat/add-posthog-trace branch May 22, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwzeng1 wwzeng1 wwzeng1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MartinYe1234 @wwzeng1