VPS Display Name Module - Supports Changed/Ok/Error #77
Conversation
Ansible module for setting the Display Name of OVH VPS system. - Take the Service Name and Display Name as parameters. - Check the current value of Display Name for Service Name via GET. - Set Display Name for Service Name if given value is different.
plugins/modules/vps_display_name.py
Outdated
| 'displayName': display_name | ||
| } | ||
|
|
||
| # Retrieve the current values for displayName, keymap and netbootMode |
There was a problem hiding this comment.
Are you retrieving those three parameters?
There was a problem hiding this comment.
Not all 3. comment is based on the OVH doc. Changed to only mention the displayName.
plugins/modules/vps_display_name.py
Outdated
| module.exit_json( | ||
| msg="displayName succesfully set to {} for {} !".format(display_name, service_name), | ||
| changed=True) | ||
| else: |
There was a problem hiding this comment.
I'm wondering if the putResult fails it will be catched in the try/except in the module_utils part 🤔
There was a problem hiding this comment.
I wasn't aware of this. It does, but the error it throws is not clear (looks like an authentication issue, instead of the real problem). Yet, I changed my code to use it.
plugins/modules/vps_display_name.py
Outdated
|
|
||
| # Retrieve the current values for displayName, keymap and netbootMode | ||
|
|
||
| getResult=client.wrap_call( |
There was a problem hiding this comment.
Please use snakecase instead of camelcase: get_result
plugins/modules/vps_display_name.py
Outdated
| # Now check if the value is different and if necessary set it | ||
|
|
||
| if getResult['displayName'] != display_name: | ||
| putResult=client.wrap_call( |
There was a problem hiding this comment.
Snakecase too: put_result
There was a problem hiding this comment.
Took the variable out, as it is no longer needed.
|
Sorry for reacting this late. Got occupied by other things and as I am pretty new to git, github and the project code, I needed a bit of time to dive in. Please let me know if you need further changes. If not, I will try to find time to write modules for other VPS endpoints, as I need them for my VPSes. |
Hi,
First code for an Ansible module for setting the Display Name of OVH VPS system.
It was started as a "copy from" the dedicated_server_display_name.py but as that code failed to do anything for my VPS-es I created my own logic. In order to be able to report Changed/Ok/Error it has to do a GET first and then, if necessary do the PUT.
Not sure if the if/then/else catches all possible errors (esp. from the GET).
Regards,
Paul Tap (armorica)