Feature html color #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was noticed it in the comment of the private tag() method, but not really possible to do. Now it is ;)
sargue
requested changes
May 31, 2017
| * version will get only the content. | ||
| * | ||
| * @param content the text content | ||
| * @param content the text content |
There was a problem hiding this comment.
Duplicated @param content, should be color.
|
Sorry, I duplicated the param but forgot to change it... Done. |
sargue
approved these changes
May 31, 2017
|
I'm having a second though about this. Reviewing the Builder class I see there is no other method like the one you propose. It seems a bit ad-hoc to me. Maybe a better solution would be just to make the |
|
I'm publishing the Do you think that's enough? |
|
I completely agree with you. I didn't want to break the public/private scope of your methods but it's more efficient in this way. Thank you. |
|
Great. I'm closing this PR and publishing a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noticed it in the comment of the private tag() method, but not
really possible to do. Now it is ;)