Integrate Latest @ 294545507

CL: 294545507
sbseltzer · Feb 25, 2020 · 061b506 · 061b506
1 parent f35a087
commit 061b506
Show file tree

Hide file tree

Showing 10 changed files with 18 additions and 14 deletions.
diff --git a/analytics/testapp/readme.md b/analytics/testapp/readme.md
@@ -9,7 +9,7 @@ with the
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.3 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

diff --git a/auth/testapp/readme.md b/auth/testapp/readme.md
@@ -10,7 +10,7 @@ with the
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.3 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

diff --git a/crashlytics/testapp/readme.md b/crashlytics/testapp/readme.md
@@ -9,7 +9,7 @@ inside the Unity Editor.
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher
-* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.3 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

diff --git a/database/testapp/readme.md b/database/testapp/readme.md
@@ -9,7 +9,7 @@ inside the Unity Editor.
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.3 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

diff --git a/dynamic_links/testapp/readme.md b/dynamic_links/testapp/readme.md
@@ -10,7 +10,7 @@ using the
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.3 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

diff --git a/functions/testapp/readme.md b/functions/testapp/readme.md
@@ -9,7 +9,7 @@ inside the Unity Editor.
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.3 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

diff --git a/messaging/testapp/readme.md b/messaging/testapp/readme.md
@@ -10,7 +10,7 @@ using the
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.3 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

diff --git a/remote_config/testapp/Assets/Firebase/Sample/RemoteConfig/UIHandler.cs b/remote_config/testapp/Assets/Firebase/Sample/RemoteConfig/UIHandler.cs
@@ -49,6 +49,7 @@ class UIHandler : MonoBehaviour {
 
     // Initialize remote config, and set the default values.
     void InitializeFirebase() {
+      // [START set_defaults]
       System.Collections.Generic.Dictionary<string, object> defaults =
         new System.Collections.Generic.Dictionary<string, object>();
 
@@ -61,6 +62,7 @@ class UIHandler : MonoBehaviour {
       defaults.Add("config_test_bool", false);
 
       Firebase.RemoteConfig.FirebaseRemoteConfig.SetDefaults(defaults);
+      // [END set_defaults]
       DebugLog("RemoteConfig configured and ready!");
       isFirebaseInitialized = true;
     }
@@ -104,18 +106,20 @@ class UIHandler : MonoBehaviour {
       }
     }
 
+    // [START fetch_async]
     // Start a fetch request.
+    // FetchAsync only fetches new data if the current data is older than the provided
+    // timespan.  Otherwise it assumes the data is "recent enough", and does nothing.
+    // By default the timespan is 12 hours, and for production apps, this is a good
+    // number. For this example though, it's set to a timespan of zero, so that
+    // changes in the console will always show up immediately.
     public Task FetchDataAsync() {
       DebugLog("Fetching data...");
-      // FetchAsync only fetches new data if the current data is older than the provided
-      // timespan.  Otherwise it assumes the data is "recent enough", and does nothing.
-      // By default the timespan is 12 hours, and for production apps, this is a good
-      // number.  For this example though, it's set to a timespan of zero, so that
-      // changes in the console will always show up immediately.
       System.Threading.Tasks.Task fetchTask = Firebase.RemoteConfig.FirebaseRemoteConfig.FetchAsync(
           TimeSpan.Zero);
       return fetchTask.ContinueWithOnMainThread(FetchComplete);
     }
+    //[END fetch_async]
 
     void FetchComplete(Task fetchTask) {
       if (fetchTask.IsCanceled) {

diff --git a/remote_config/testapp/readme.md b/remote_config/testapp/readme.md
@@ -10,7 +10,7 @@ using the
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.3 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).

diff --git a/storage/testapp/readme.md b/storage/testapp/readme.md
@@ -9,7 +9,7 @@ inside the Unity Editor.
 ## Requirements
 
 * [Unity](http://unity3d.com/) 5.3 or higher.
-* [Xcode](https://developer.apple.com/xcode/) 10.1 or higher
+* [Xcode](https://developer.apple.com/xcode/) 10.3 or higher
   (when developing for iOS).
 * [Android SDK](https://developer.android.com/studio/index.html#downloads)
   (when developing for Android).