-
-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multinomial LogisticRegressionCV with lbfgs non-deterministic on Travis Mac OS #11924
Comments
These kinds of cross-platform inconsistencies often come from things like uninitialised memory... Not sure where to look. |
At #11925 I was trying to identify whether the discrepancy came from the initial fits for each fold, or from the refit process in LogisticRegressionCV (as this would make sense for why it's broken only for the CV variant). From https://travis-ci.org/scikit-learn/scikit-learn/jobs/421403473#L375 we see that while the binary logistic fits produce an identical model each time, the mean coefficients of the best model from CV are slightly different across repeated runs (and I'm not sure we should be using the mean here): (multi_class='auto')
vs
Using these as the initial coefficients results in a vastly discrepant refit:
vs
|
I think this can't be just about LogisticRegressionCV. At https://travis-ci.org/scikit-learn/scikit-learn/jobs/421410785, for two of the three KFold splits, we get identical coefficients. For the third split, one fit gets:
The other gets:
Which seems quite different. |
The fact that this occurs when I'm wondering if we should just skip the test on mac: I presume that this same bug was present, but not tested for, in 0.19, so it's not really release sensitive!! |
Thanks for investigating this! +1 to skip that assert for now. |
I have the same problem on MacOS, that the test of LogisticRegressionCV with newton-cg fail nearly all the time and rarely the test LogisticRegression with newton-cg fails as well.
|
Please provide the output of show_versions()
|
Sorry, the solver lbfgs doesn't actually fail, so I opened a new Issue #16279. |
Can we close this issue? BTW, this issue seems to focus on |
Okay, lets close this issue as the CI on macOS has been passing for a while, along with the wheel building on OSX. |
See MacPython/scikit-learn-wheels#7 (comment)
The text was updated successfully, but these errors were encountered: