MNT fix cd_fast.pyx warning issues #13397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also makes the tests in #12682 pass :) |
amueller
reviewed
Mar 5, 2019
amueller
reviewed
Mar 5, 2019
|
can we test this some way? maybe making sure that something doesn't raise a warning? |
I'll try to add some tests. |
|
otherwise looks good btw |
|
Added some tests, #12682 also include some tests checking for presence and absence of convergence warnings. |
agramfort
approved these changes
Mar 5, 2019
|
I suppose I can merge then :) |
|
Good job!!! |
|
Sweet, thanks! |
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
* fix warning issues * add comments * add some tests * pep8
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 7bcc701.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 7bcc701.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
* fix warning issues * add comments * add some tests * pep8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13394
This fixes issues with the "Objective did not converge...." warnings.
There were some indentation and missing
elseissues.