[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX accept NumPy arrays for alphas in GraphicalLassoCV #22493

Merged
merged 5 commits into from
Feb 15, 2022
Merged

FIX accept NumPy arrays for alphas in GraphicalLassoCV #22493

merged 5 commits into from
Feb 15, 2022

Conversation

glemaitre
Copy link
Member

closes #22489

I checked and it was the only location where we had this issue with collections.abc.Sequence.

jeremiedbb
jeremiedbb approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @glemaitre

@jeremiedbb jeremiedbb added the Quick Review For PRs that are quick to review label Feb 15, 2022
thomasjpfan
thomasjpfan approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit abbee57 into scikit-learn:main Feb 15, 2022
@glemaitre glemaitre mentioned this pull request Feb 17, 2022
Merged
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
@glemaitre @thomasjpfan
FIX accept NumPy arrays for alphas in GraphicalLassoCV (scikit-learn#…
aeddf8f 
…22493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:covariance Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should not use collections.abc.Sequence to ducktype ndarray
3 participants
@glemaitre @thomasjpfan @jeremiedbb