-
-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Config: change default display to "diagram" #22856
API Config: change default display to "diagram" #22856
Conversation
It does not seem to work as expected: |
Actually it is, you're missing the |
Indeed. I forgot that the code of code snippets in the user guide is not executed by sphinx as done in the examples... We already have the problem on the dev site: https://scikit-learn.org/dev/modules/compose.html#visualizing-composite-estimators so this is not a problem of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this.
import sklearn | ||
|
||
sklearn.set_config(display="diagram") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: it seems that we actually do not display the pipeline diagram in this example but I think this is fine.
Hi all, After I updated from v1.0.2 to v1.1.2, a normal notebook calling a sklearn.ensemble.RandomForestRegression object would yield the following error in this actions result. I then included the language as follows at the beginning of notebooks, and it did improve.
So long story short is that this change in the default options might introduce some hard-to-debut errors, such as in this case a |
The issue comes from |
Many thanks for this fast iteration - it will be very welcome indeed if this use case is supported! Not only it would align with the other use cases, but it also would take away the need to re-adjust the parameter to its older default. |
Fixes #21285