FIX Fixes HTML repr when get_params contains classes #24512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2022
glemaitre
approved these changes
Sep 30, 2022
adrinjalali
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Thanks @thomasjpfan .
This is related to #24545, but I think the fix to that issue would be #24545 (comment)
|
I think this is already a net improvement. Merging. |
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes issue seen in #22856 (comment)
Fixes #24545 (comment)
What does this implement/fix? Explain your changes.
The underlying issue comes from
get_paramsreturning a estimator class as a key and not instances. This PR skips classes in the repr.