[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT crop properly the image in fetch_lfw_people #24951

Merged
merged 5 commits into from
Nov 16, 2022
Merged

MAINT crop properly the image in fetch_lfw_people #24951

merged 5 commits into from
Nov 16, 2022

Conversation

glemaitre
Copy link
Member
@glemaitre glemaitre commented Nov 15, 2022 •
edited
Loading

closes #24942

Assign cropped image in fetch_lfw_people.

TODO:

  • add non-regression test.

@glemaitre glemaitre added this to the 1.2 milestone Nov 15, 2022
@glemaitre glemaitre marked this pull request as draft November 16, 2022 09:43
@glemaitre glemaitre marked this pull request as ready for review November 16, 2022 09:58
jeremiedbb
jeremiedbb reviewed Nov 16, 2022
View reviewed changes
doc/whats_new/v1.2.rst Outdated Show resolved Hide resolved
jeremiedbb
jeremiedbb approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremiedbb jeremiedbb merged commit 3714c90 into scikit-learn:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
Blocker module:datasets
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

Bug in fetch_lfw_people() function
2 participants
@glemaitre @jeremiedbb