ENH implement metadata routing in Pipeline #26789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 tasks
|
@thomasjpfan @glemaitre this should also be ready for a review |
|
@OmarManzoor I'd also appreciate your feedback on this. |
OmarManzoor
reviewed
Jul 12, 2023
OmarManzoor
reviewed
Jul 12, 2023
glemaitre
reviewed
Jul 12, 2023
| try: | ||
| getattr(pipeline, method)([[1]], [1], sample_weight=[1], prop="a") | ||
| except TypeError: | ||
| getattr(pipeline, method)([[1]], sample_weight=[1], prop="a") |
There was a problem hiding this comment.
We should mention why we bypass the TypeError. I assume this is for estimators that only accept X?
There was a problem hiding this comment.
not estimators, methods. fit takes X, y, while predict takes only X. I'll add a comment.
adrinjalali
commented
Jul 12, 2023
| try: | ||
| getattr(pipeline, method)([[1]], [1], sample_weight=[1], prop="a") | ||
| except TypeError: | ||
| getattr(pipeline, method)([[1]], sample_weight=[1], prop="a") |
There was a problem hiding this comment.
not estimators, methods. fit takes X, y, while predict takes only X. I'll add a comment.
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #22893
This adds metadata routing to pipeline.
Closes #21134
Closes #18159
Closes #24507