-
-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add warp::ws2() as a more flexible websocket filter #34
Conversation
@seanmonstar What is the rationale behind the name |
@scrogson I'd expect them to replace the existing |
@seanmonstar FWIW I've seen |
Does this mean that
In my opinion (and I could be completely wrong or mean to suggest this, but...), anything
I guess my biggest complaint is seeing version numbers in the types rather than a module namespace. Coming from the Erlang/Elixir world, it's not completely obvious if it's a versioning thing or the arity of the function. In Erlang the arity of a function is often used to document functions: |
Yes, though rather, in 0.2.0. In the Rust community (and the way cargo interprets semver), it's expected that upgrading a patch version of 0.x.y to 0.x.z will continue to compile. Cargo will eagerly download the newest patch version.
I've seen it far more often as "this is the newer version", with several examples in the futures crate. Though, it also happens to have a couple examples of including arity in the name, like I've also occasionally seen |
Thanks @seanmonstar, this API will do what I need. |
Good to know, thanks for taking the time to explain 👍 |
You could always go straight to 0.2.0 now, rather than getting people to switch to a |
@jnicholls FWIW @seanmonstar described his rationale in #14 (comment) as "I'll probably hold off on a breaking change for at least a little bit, so that these papercuts can be grouped up." |
@kellytk Indeed, fair enough! :) Thanks. |
Motivated by #29
cc @caolan