Added a verification to only update fields that are valid.

sebas5384 · Dec 5, 2017 · f6737b4 · f6737b4
1 parent 78c4f2f
commit f6737b4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/modules/editor/containers/NodeEditor.js b/src/modules/editor/containers/NodeEditor.js
@@ -8,6 +8,7 @@ import isHotKey from 'is-hotkey'
 
 import { getSelectedNode, updateNodeFields } from '../store'
 import { deserializeFields, serializeFields } from '../lib/serializers'
+import { fieldIsInvalid } from '../lib/helpers';
 
 const Wrapper = styled.section``
 
@@ -143,6 +144,9 @@ const componentWillMount = function () {
 const handleOnChange = ({ node, dispatch, setValue }) => ({ value }) => {
   // Deserialize value to [ { name, type }, { name, type } ].
   const fields = serializeFields(value.toJS())
+
+  // Avoid creating invalid types.
+  if (fields.some(fieldIsInvalid)) return setValue(value)
 
   // Dispatch an action to save the unserialized value to node.fields[].
   // @TODO [ASAP] Find better perfomance, for ex. debaunce the dispatching.

diff --git a/src/modules/editor/store.js b/src/modules/editor/store.js
@@ -65,6 +65,7 @@ export const getModelFromRelation = ({ edges, nodeB }) => {
   if (!edge) return
   return edge.nodes[1]
 }
+export const typeToModel = type => type.replace(/[^A-Za-z_]*/g, '')
 
 /*
  * Initial State.