api: set session as "closed" to avoid reinsertion in active_sessions

Co-authored-by: vsaller <vsaller@yahoo.com> Co-authored-by: Luis Gustavo S. Barreto <gustavo@ossystems.com.br>
shellhub-io · Jul 30, 2021 · 6ead3a7 · 6ead3a7
1 parent cff11a0
commit 6ead3a7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/api/store/mongo/session_store.go b/api/store/mongo/session_store.go
@@ -178,6 +178,10 @@ func (s *Store) SessionSetLastSeen(ctx context.Context, uid models.UID) error {
 		return fromMongoError(err)
 	}
 
+	if session.Closed {
+		return nil
+	}
+
 	session.LastSeen = clock.Now()
 
 	opts := options.Update().SetUpsert(true)
@@ -205,6 +209,8 @@ func (s *Store) SessionDeleteActives(ctx context.Context, uid models.UID) error
 	}
 
 	session.LastSeen = clock.Now()
+	session.Closed = true
+
 	opts := options.Update().SetUpsert(true)
 	_, err := s.db.Collection("sessions").UpdateOne(ctx, bson.M{"uid": session.UID}, bson.M{"$set": session}, opts)
 	if err != nil {

diff --git a/pkg/models/session.go b/pkg/models/session.go
@@ -14,6 +14,7 @@ type Session struct {
 	StartedAt     time.Time `json:"started_at" bson:"started_at"`
 	LastSeen      time.Time `json:"last_seen" bson:"last_seen"`
 	Active        bool      `json:"active" bson:",omitempty"`
+	Closed        bool      `json:"-" bson:"closed"`
 	Authenticated bool      `json:"authenticated" bson:"authenticated"`
 	Recorded      bool      `json:"recorded" bson:"recorded"`
 }