ui: fix device delete permission in device details

Signed-off-by: Leonardo R.S. Joao <leonardo.joao@ossystems.com.br>
shellhub-io · Feb 23, 2022 · b8c089e · b8c089e
1 parent 201a572
commit b8c089e
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 14 deletions.
diff --git a/ui/src/components/device/DeviceDetails.vue b/ui/src/components/device/DeviceDetails.vue
@@ -88,14 +88,33 @@
               </span>
             </v-tooltip>
 
-            <v-list-item @click.stop="openDialog('deviceDeleteShow')">
-              <DeviceDelete
-                :uid="device.uid"
-                :redirect="true"
-                :show.sync="deviceDeleteShow"
-                data-test="deviceDelete-component"
-              />
-            </v-list-item>
+            <v-tooltip
+              bottom
+              :disabled="hasAuthorizationRemove"
+            >
+              <template #activator="{ on, attrs }">
+                <div
+                  v-bind="attrs"
+                  v-on="on"
+                >
+                  <v-list-item
+                    :disabled="!hasAuthorizationRemove"
+                    @click.stop="openDialog('deviceDeleteShow')"
+                  >
+                    <DeviceDelete
+                      :uid="device.uid"
+                      :redirect="true"
+                      :show.sync="deviceDeleteShow"
+                      data-test="deviceDelete-component"
+                    />
+                  </v-list-item>
+                </div>
+              </template>
+
+              <span>
+                You don't have this kind of authorization.
+              </span>
+            </v-tooltip>
           </v-card>
         </v-menu>
       </v-toolbar>
@@ -233,6 +252,7 @@ export default {
       deviceDeleteShow: false,
       renameAction: 'rename',
       updateAction: 'deviceUpdate',
+      removeAction: 'remove',
     };
   },
 
@@ -260,6 +280,18 @@ export default {
 
       return false;
     },
+
+    hasAuthorizationRemove() {
+      const role = this.$store.getters['auth/role'];
+      if (role !== '') {
+        return hasPermission(
+          this.$authorizer.role[role],
+          this.$actions.device[this.removeAction],
+        );
+      }
+
+      return false;
+    },
   },
 
   async created() {

diff --git a/ui/tests/unit/components/device/__snapshots__/DeviceDetails.spec.js.snap b/ui/tests/unit/components/device/__snapshots__/DeviceDetails.spec.js.snap
@@ -23,9 +23,9 @@ exports[`DeviceDetails Offline Device Renders the component 1`] = `
           <v-tooltip-stub opendelay="0" closedelay="0" bottom="true" openonclick="true" openonhover="true" openonfocus="true" contentclass="" maxwidth="auto" nudgebottom="0" nudgeleft="0" nudgeright="0" nudgetop="0" nudgewidth="0" tag="span"> <span>
               You don't have this kind of authorization.
             </span></v-tooltip-stub>
-          <v-list-item-stub activeclass="" tag="div">
-            <devicedelete-stub uid="a582b47a" redirect="true" data-test="deviceDelete-component"></devicedelete-stub>
-          </v-list-item-stub>
+          <v-tooltip-stub opendelay="0" closedelay="0" bottom="true" openonclick="true" openonhover="true" openonfocus="true" contentclass="" maxwidth="auto" nudgebottom="0" nudgeleft="0" nudgeright="0" nudgetop="0" nudgewidth="0" tag="span"> <span>
+              You don't have this kind of authorization.
+            </span></v-tooltip-stub>
         </v-card-stub>
       </v-menu-stub>
     </v-toolbar-stub>
@@ -120,9 +120,9 @@ exports[`DeviceDetails Online Device and owner Renders the component 1`] = `
           <v-tooltip-stub opendelay="0" closedelay="0" bottom="true" disabled="true" openonclick="true" openonhover="true" openonfocus="true" contentclass="" maxwidth="auto" nudgebottom="0" nudgeleft="0" nudgeright="0" nudgetop="0" nudgewidth="0" tag="span"> <span>
               You don't have this kind of authorization.
             </span></v-tooltip-stub>
-          <v-list-item-stub activeclass="" tag="div">
-            <devicedelete-stub uid="a582b47a" redirect="true" data-test="deviceDelete-component"></devicedelete-stub>
-          </v-list-item-stub>
+          <v-tooltip-stub opendelay="0" closedelay="0" bottom="true" disabled="true" openonclick="true" openonhover="true" openonfocus="true" contentclass="" maxwidth="auto" nudgebottom="0" nudgeleft="0" nudgeright="0" nudgetop="0" nudgewidth="0" tag="span"> <span>
+              You don't have this kind of authorization.
+            </span></v-tooltip-stub>
         </v-card-stub>
       </v-menu-stub>
     </v-toolbar-stub>