ui: remove v-if in fragment

This commit removes the v-if because it's not good programming practice to put it in the template. And change tests to uses table drive model. Signed-off-by: Leonardo R.S. Joao <leonardo.joao@ossystems.com.br>
shellhub-io · Feb 10, 2022 · f92731c · f92731c
1 parent cfc0d71
commit f92731c
Show file tree

Hide file tree

Showing 8 changed files with 554 additions and 292 deletions.
diff --git a/ui/src/components/session/SessionDetails.vue b/ui/src/components/session/SessionDetails.vue
@@ -62,7 +62,7 @@
 
           <v-card>
             <v-list-item
-              v-if="session.recorded"
+              v-if="session.recorded && isEnterprise"
               @click.stop="openDialog('sessionPlayDialog')"
             >
               <SessionPlay
@@ -253,6 +253,12 @@ export default {
     };
   },
 
+  computed: {
+    isEnterprise() {
+      return this.$env.isEnterprise;
+    },
+  },
+
   async created() {
     this.uid = this.$route.params.id;
     try {

diff --git a/ui/src/components/session/SessionList.vue b/ui/src/components/session/SessionList.vue
@@ -130,7 +130,7 @@
               </v-list-item>
 
               <v-list-item
-                v-if="item.authenticated && item.recorded"
+                v-if="item.authenticated && item.recorded && isEnterprise"
                 @click.stop="showSessionPlay(getListSessions.indexOf(item))"
               >
                 <SessionPlay
@@ -236,6 +236,10 @@ export default {
     getNumberSessions() {
       return this.$store.getters['sessions/getNumberSessions'];
     },
+
+    isEnterprise() {
+      return this.$env.isEnterprise;
+    },
   },
 
   watch: {

diff --git a/ui/src/components/session/SessionPlay.vue b/ui/src/components/session/SessionPlay.vue
@@ -1,8 +1,5 @@
 <template>
-  <fragment
-    v-if="hidden()"
-    data-test="render-fragment"
-  >
+  <fragment>
     <v-tooltip
       v-if="recorded"
       :disabled="hasAuthorization"
@@ -430,10 +427,6 @@ export default {
         );
       }
     },
-
-    hidden() {
-      return this.$env.isEnterprise;
-    },
   },
 };