[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the delete button #140

Merged
merged 3 commits into from
Feb 28, 2021
Merged

Fixed the delete button #140

merged 3 commits into from
Feb 28, 2021

Conversation

Saransh-cpp
Copy link
Contributor
@Saransh-cpp Saransh-cpp commented Feb 28, 2021 •
edited
Loading

Closes #139

Changes

  1. Added logic for removing the PDF from both the boxes (pdf and starred) together, once the user clicks the delete button.
  2. Added a confirmation dialogue box for the delete option.

The major changes are from line 215 to line 299 in Home.dart.

Please let me know if any changes are required. Thanks!

(MWoC and CWoC participant)

@smaranjitghose
Copy link
Owner

@Saransh-cpp could you please compare your score on the MWOC leaderboard and your PRs to this repo, therby letting us know of any discrepencies

@smaranjitghose smaranjitghose merged commit d754993 into smaranjitghose:main Feb 28, 2021
@pr-triage pr-triage bot added the PR: merged label Feb 28, 2021
@Saransh-cpp
Copy link
Contributor Author

@Saransh-cpp could you please compare your score on the MWOC leaderboard and your PRs to this repo, therby letting us know of any discrepencies

3 of my PRs which were merged yesterday are not being reflected on the leaderboard. PR - #132 , #134 and #137 . The labels were added but the workflow didn't work. The score for this PR was reflected so I guess the workflow is working fine now, please communicate with the organizers for those 3 PRs.

@smaranjitghose
Copy link
Owner

@Saransh-cpp could you please compare your score on the MWOC leaderboard and your PRs to this repo, therby letting us know of any discrepencies

3 of my PRs which were merged yesterday are not being reflected on the leaderboard. PR - #132 , #134 and #137 . The labels were added but the workflow didn't work. The score for this PR was reflected so I guess the workflow is working fine now, please communicate with the organizers for those 3 PRs.

I'll definitely forward this to the orgainzers.
Could you please let me know the total no PRs merged for you(w.r.t this project) and total score as of now

@Saransh-cpp
Copy link
Contributor Author

Yes sure, 27 merged, 2 open. Score as of now on the leaderboard is 1125, the score should be 1125+225 that is 1350. 225 is the score for those 3 PRs (+100+100+25)

@Saransh-cpp
Copy link
Contributor Author

@smaranjitghose this PR also does not contain the CrossWOC and difficulty labels. This is the last one for CrossWOC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaranjitghose smaranjitghose smaranjitghose approved these changes

Assignees
No one assigned
Labels
CrossWOC graded Hard MWOC Mexili Winter of Code PR: merged user=Saransh-cpp:score=100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The delete PDF option improvements
2 participants
@Saransh-cpp @smaranjitghose