[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #154 Padding issue fixed and reduced repeated code #155

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

mohitsoni-dev
Copy link
Contributor

No description provided.

@mohitsoni-dev mohitsoni-dev changed the title Padding issue fixed and reduced repeated code For #154 Padding issue fixed and reduced repeated code Mar 9, 2021
@arteevraina
Copy link

@mohitsoni-dev please update your PR with some description. It can include stuff like which issue you fixed and what changes you made. Screenshots if necessary. :)

@mohitsoni-dev
Copy link
Contributor Author

Reduced repeated code by extracting the Expanded widget and added needed padding to the text. Extracted widget:-

class SettingText extends StatelessWidget {
  SettingText({@required this.text});
  final String text;
  @override
  Widget build(BuildContext context) {
    return Expanded(
      flex: 3,
      child: Padding(
        padding: const EdgeInsets.all(8.0),
        child: Text(
          text,
          style: TextStyle(
            height: 1,
            fontSize: 17,
          ),
        ),
      ),
    );
  }
}

Before & After
before before

Please inform me if any changes are needed in this PR. Thanks.

),
SettingText(
text:
'When auto-capturing , let me adjust borders after each scan'),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformat this as well.

),
),
SettingText(
text: 'Run text recognition on saved pdf'),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformat this.

}

class SettingText extends StatelessWidget {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding this class in a separate file. But would like to have @anushbhatia 's view on this as well.

Copy link
@arteevraina arteevraina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes. Other than that PR looks good. Nice Work 🎊

@mohitsoni-dev
Copy link
Contributor Author

Understood. I'll make the suggested changes and make update the PR. Thanks.

@mohitsoni-dev
Copy link
Contributor Author

It seems there is some problem with the lint test maybe it's outdated. @arteevraina please respond to this. Thanks.

@arteevraina
Copy link
arteevraina commented Mar 11, 2021

flutter analyze is failing because there are a lot of warnings in the code itself that's why it's failing. Not specifically about your code. I think this should be dealt in a separate issue. Ref: #161

@smaranjitghose smaranjitghose added the gssoc21 GirlScript Summer of Code 2021 label Mar 12, 2021
@smaranjitghose smaranjitghose merged commit ee0cb7e into smaranjitghose:main Mar 12, 2021
@pr-triage pr-triage bot added the PR: merged label Mar 12, 2021
@mohitsoni-dev mohitsoni-dev deleted the leftPaddingSettings branch March 13, 2021 03:37
@smaranjitghose smaranjitghose added Level2 GSSOC Bug fixing, adding small features and removed PR: reviewed-approved labels May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc21 GirlScript Summer of Code 2021 Level2 GSSOC Bug fixing, adding small features PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants