-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For #154 Padding issue fixed and reduced repeated code #155
For #154 Padding issue fixed and reduced repeated code #155
Conversation
@mohitsoni-dev please update your PR with some description. It can include stuff like which issue you fixed and what changes you made. Screenshots if necessary. :) |
Reduced repeated code by extracting the Expanded widget and added needed padding to the text. Extracted widget:-
Please inform me if any changes are needed in this PR. Thanks. |
lib/settings.dart
Outdated
), | ||
SettingText( | ||
text: | ||
'When auto-capturing , let me adjust borders after each scan'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reformat this as well.
lib/settings.dart
Outdated
), | ||
), | ||
SettingText( | ||
text: 'Run text recognition on saved pdf'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reformat this.
lib/settings.dart
Outdated
} | ||
|
||
class SettingText extends StatelessWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding this class in a separate file. But would like to have @anushbhatia 's view on this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes. Other than that PR looks good. Nice Work 🎊
Understood. I'll make the suggested changes and make update the PR. Thanks. |
It seems there is some problem with the lint test maybe it's outdated. @arteevraina please respond to this. Thanks. |
|
No description provided.