[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rename option is now compatible with the starred documents feature #151

Merged

Conversation

Saransh-cpp
Copy link
Contributor

Fixes #149

Changes

  1. Now when a starred document is renamed, it is not removed from the starred box automatically.
  2. Whenever a document is renamed in the pdfs box, if the same document also exists in the starred box, it is also renamed to maintain consistency and to remove all the previous issues.

Major changes in the onTap of Rename feature, rest of the file was automatically formatted in my IDE.

Please review and let me know if any changes are required.
(GSSoC and CWoC participant)

@smaranjitghose smaranjitghose merged commit 0b80687 into smaranjitghose:main Mar 8, 2021
@Saransh-cpp
Copy link
Contributor Author

@smaranjitghose can you please add the relevant labels?

@smaranjitghose
Copy link
Owner

@smaranjitghose can you please add the relevant labels?

Which ones do you need? GSSOC?

@Saransh-cpp
Copy link
Contributor Author

@smaranjitghose can you please add the relevant labels?

Which ones do you need? GSSOC?

Yes GSSoC and CWoC

@smaranjitghose smaranjitghose added CrossWOC gssoc21 GirlScript Summer of Code 2021 Level3 GSSOC New features, major bug fixing. Medium labels Mar 12, 2021
@smaranjitghose
Copy link
Owner

@Saransh-cpp Could you please check your PRs and lemme know(tag me in a comment) where we might have missed out the CrossWoc or GSSOC tag for you

@Saransh-cpp
Copy link
Contributor Author

@Saransh-cpp Could you please check your PRs and lemme know(tag me in a comment) where we might have missed out the CrossWoc or GSSOC tag for you

Sure, I will look into my PRs and tag you in the necessary places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CrossWOC gssoc21 GirlScript Summer of Code 2021 Level3 GSSOC New features, major bug fixing. Medium PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Renaming a PDF removes it from starred documents
2 participants