-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Logo and Splashscreen. #16
Added Logo and Splashscreen. #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with the home screen @Vrushti24🙌🙌🙌 but don't modify the side nav as it is not working now please resolve that rest everything is working fine.
Can u explain me in detail what is not working on side nav because I
changed only logo nothing else and I checked that It was working fine so
please let me know in detail about the issue
And thank u .
…On Thu, Dec 31, 2020, 10:39 PM Anush Bhatia ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Great work with the home screen @Vrushti24 <https://github.com/Vrushti24>
🙌🙌🙌 but don't modify the side nav as it is not working now please
resolve that rest everything is working fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSFIKSMEHKH6SKJPY3DSXSV4NANCNFSM4VOCBRJQ>
.
|
@override | ||
Widget build(BuildContext context) { | ||
return MaterialApp( | ||
home: SplashScreen(), | ||
debugShowCheckedModeBanner: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't modify the icon I will provide the nav icon soon as it does currently not function.
Okay great I will do that
…On Thu, Dec 31, 2020, 10:43 PM Anush Bhatia ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/main.dart
<#16 (comment)>
:
> @OverRide
Widget build(BuildContext context) {
return MaterialApp(
- home: SplashScreen(),
+ debugShowCheckedModeBanner: false,
Don't modify the icon I will provide the nav icon soon as it does
currently not function.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSEBSN5EOP4KRU4NDRDSXSWNFANCNFSM4VOCBRJQ>
.
|
I will remove the icon from maindrawer.dart ?
…On Thu, Dec 31, 2020, 10:44 PM Vrushti Shah ***@***.***> wrote:
Okay great I will do that
On Thu, Dec 31, 2020, 10:43 PM Anush Bhatia ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In lib/main.dart
> <#16 (comment)>
> :
>
> > @OverRide
> Widget build(BuildContext context) {
> return MaterialApp(
> - home: SplashScreen(),
> + debugShowCheckedModeBanner: false,
>
> Don't modify the icon I will provide the nav icon soon as it does
> currently not function.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#16 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ARFAUSEBSN5EOP4KRU4NDRDSXSWNFANCNFSM4VOCBRJQ>
> .
>
|
Android.Emulator.-.Nexus_5X_API_R_5554.2020-12-31.22-47-41.mp4 |
I got it i will change that thanks
…On Thu, Dec 31, 2020, 10:52 PM Anush Bhatia ***@***.***> wrote:
https://user-images.githubusercontent.com/40017559/103419850-c1104000-4bba-11eb-898b-787cf1921b90.mp4
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSBEK7DKFJMI5GVCMWLSXSXLTANCNFSM4VOCBRJQ>
.
|
I have made the changes and even side nav is also working now how can I add
this to GitHub again Same process like before ?
…On Thu, Dec 31, 2020, 10:54 PM Vrushti Shah ***@***.***> wrote:
I got it i will change that thanks
On Thu, Dec 31, 2020, 10:52 PM Anush Bhatia ***@***.***>
wrote:
>
> https://user-images.githubusercontent.com/40017559/103419850-c1104000-4bba-11eb-898b-787cf1921b90.mp4
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#16 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ARFAUSBEK7DKFJMI5GVCMWLSXSXLTANCNFSM4VOCBRJQ>
> .
>
|
I have updated PR #16 please check it if this is properly updated thank u
…On Thu, Dec 31, 2020, 11:43 PM Vrushti Shah ***@***.***> wrote:
I have made the changes and even side nav is also working now how can I
add this to GitHub again Same process like before ?
On Thu, Dec 31, 2020, 10:54 PM Vrushti Shah ***@***.***>
wrote:
> I got it i will change that thanks
>
> On Thu, Dec 31, 2020, 10:52 PM Anush Bhatia ***@***.***>
> wrote:
>
>>
>> https://user-images.githubusercontent.com/40017559/103419850-c1104000-4bba-11eb-898b-787cf1921b90.mp4
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#16 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ARFAUSBEK7DKFJMI5GVCMWLSXSXLTANCNFSM4VOCBRJQ>
>> .
>>
>
|
@anushbhatia I hope that the issue is solved U can check now PR #16 |
Thank you!
…On Sat, Jan 2, 2021, 11:57 PM Anush Bhatia ***@***.***> wrote:
Merged #16 <#16> into main.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSBMPBI6ZSO6DNJUPT3SX5QSJANCNFSM4VOCBRJQ>
.
|
No description provided.