About us #40
Closed
About us #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attach a screenshot of the app screen post your changes |
|
Yeah sure
…On Sun, Jan 24, 2021, 2:17 PM Smaranjit Ghose ***@***.***> wrote:
Attach a screenshot of the app screen post your changes
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSFKKJKINUILFJEAWPLS3PNBDANCNFSM4WP4RZCQ>
.
|
|
I have changed the background added some images to make it look more attractive |
|
Sir there is no level tag how can I come to know which level it is ?
…On Sun, Jan 24, 2021, 2:17 PM Vrushti Shah ***@***.***> wrote:
Yeah sure
On Sun, Jan 24, 2021, 2:17 PM Smaranjit Ghose ***@***.***>
wrote:
> Attach a screenshot of the app screen post your changes
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#40 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ARFAUSFKKJKINUILFJEAWPLS3PNBDANCNFSM4WP4RZCQ>
> .
>
|
anushbhatia
requested changes
Jan 25, 2021
There was a problem hiding this comment.
- Illustrations are not in proper alignment as they are getting stretched instead of putting all information in one place you can instead.
- Don't add a weird background keep it white as of now later we will add other colours to it.
- the text "Made with Open source" is not visible on the screen due to navigation icons.
- Update your flutter to the latest version. It is having a lot of minor issues I have to rectify them every time I see it.
|
I think the problem is with Adobe XD so should I do this is again or change in this only ?? Because whenever I will open again in my it will appear proper only so should I do it again in normal I mean not in Adobe XD?? |
|
There's no problem with adobe xd the illustrations dimensions need to be maintained when imporring the illustrations. Pixels of height and width should be reduced in a ratio so that image does not get stretched. So try reducing the size of image and incorporating the same image here. |
|
Ok, will do that.
…On Mon, Jan 25, 2021, 6:12 PM Anush Bhatia ***@***.***> wrote:
There's no problem with adobe xd the illustrations dimensions need to be
maintained when imporring the illustrations. Pixels of height and width
should be reduced in a ratio so that image does not get stretched. So try
reducing the size of image and incorporating the same image here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSHJLN6BCAYWMTP6UFTS3VRMFANCNFSM4WP4RZCQ>
.
|
|
Do a squash commit please |
|
Okay, how to do Squash commit?
…On Wed, Jan 27, 2021, 1:46 AM Smaranjit Ghose ***@***.***> wrote:
Do a squash commit please
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSGTT5T5TVTQFWF7QS3S34PIXANCNFSM4WP4RZCQ>
.
|
|
I don't know how to do squash commit. My changes were reflected before u
said to do squash commit so what do I do now ?
…On Wed, Jan 27, 2021, 9:33 AM Vrushti Shah ***@***.***> wrote:
Okay
On Wed, Jan 27, 2021, 1:46 AM Smaranjit Ghose ***@***.***>
wrote:
> Do a squash commit please
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#40 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ARFAUSGTT5T5TVTQFWF7QS3S34PIXANCNFSM4WP4RZCQ>
> .
>
|
|
Hey nice explanation thanks for video I will do that
…On Fri, Jan 29, 2021, 12:10 PM Anush Bhatia ***@***.***> wrote:
https://www.youtube.com/watch?v=viY1BbKZhSI
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSBHNZWT7J6ELLWYYILS4JJ7TANCNFSM4WP4RZCQ>
.
|
Please spend some time before shooting queries. We are always there to guide you but we expect you to search for fundamental concepts on google and stackoverflow first |
|
Yeah
On Sun, Jan 31, 2021, 4:36 AM Smaranjit Ghose <notifications@github.com>
wrote:
… Okay, how to do Squash commit?
… <#m_-6822358681463463579_>
On Wed, Jan 27, 2021, 1:46 AM Smaranjit Ghose *@*.***> wrote: Do a squash
commit please — You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#40 (comment)
<#40 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARFAUSGTT5T5TVTQFWF7QS3S34PIXANCNFSM4WP4RZCQ
.
Please spend some time before shooting queries. We are always there to
guide you but we expect you to search for fundamental concepts on google
and stackoverflow first
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSB3QKAG6J4YO3ZA52LS4SGIXANCNFSM4WP4RZCQ>
.
|
|
Semd the screenshot of page as soon as it is completed |
|
Will do,
…On Tue, Feb 2, 2021, 11:01 PM Anush Bhatia ***@***.***> wrote:
Semd the screenshot of page as soon as it is completed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSATFV7YFG2RQJIMBKDS5AZHHANCNFSM4WP4RZCQ>
.
|
|
Raise a new PR for your changes |
|
Okay
…On Wed, Feb 3, 2021, 7:22 PM Smaranjit Ghose ***@***.***> wrote:
Closed #40 <#40>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSELLYUCDSZ2XBOISD3S5FIKNANCNFSM4WP4RZCQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.