[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented dark theme #81

Merged

Conversation

Saransh-cpp
Copy link
Contributor
@Saransh-cpp Saransh-cpp commented Feb 8, 2021

Closes #74

Settings page now offers a switch which can be used to turn on the dark mode.

A big PR, please merge this before merging other PRs as resolving conflicts in this would be very difficult. Please let me know if any changes required. Thank you so much!

And please let me know how will my scores be updated or reflected on the MWoC's official leaderboard which is present on their site.

Copy link
Collaborator
@anushbhatia anushbhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new logos in the assets folder which can be added to the dark mode of the page and also add dark mode to the review page too

@Saransh-cpp
Copy link
Contributor Author

Added new logos in the assets folder which can be added to the dark mode of the page and also add dark mode to the review page too

Is the rating dialogue and the review page same? or else can you please provide me with the path for the page, I can't locate it.

@anushbhatia
Copy link
Collaborator

Yes they are same

@Saransh-cpp
Copy link
Contributor Author
Saransh-cpp commented Feb 8, 2021

Rating dialogue actually has only a single colour property which is accent colour. I have already applied that to be dynamic but I can't find the complete box's colour property.

Edit: Don't merge yet, I will have to take some suggestions for the icons. I will do that tomorrow morning.

@anushbhatia
Copy link
Collaborator

Sure no problem

@Saransh-cpp
Copy link
Contributor Author

The review dialogue, please let me know if you want any changes.

Screenshot_1612858672
Screenshot_1612858689

The logo in About.dart, please let me know if you want any changes.

Screenshot_1612858684
Screenshot_1612858675

@Saransh-cpp
Copy link
Contributor Author

Please let me know if there are any further changes you want. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Implementing theme change option
3 participants