[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attributes from the Manifest #5

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Remove attributes from the Manifest #5

merged 1 commit into from
Feb 4, 2017

Conversation

sdoward
Copy link
Contributor
@sdoward sdoward commented Feb 1, 2017 •
edited
Loading

Including these definitions forces the manifest merger to fail if any of the attributes conflict.

screen shot 2017-02-01 at 12 44 01

If conflicts don't exist then the consumers of the lib will use the attributes defined here.

So this PR removes this

@sdoward
Remove attributes from the Manifest
4302b3d 
Including these definitions forces the manifest merger to fail if any of the attributes conflict. If conflicts don't exist they the consumers of the lib will use the attributes defined here.
@sockeqwe sockeqwe merged commit 109ccdc into sockeqwe:master Feb 4, 2017
@sockeqwe
Copy link
Owner
sockeqwe commented Feb 4, 2017

Thanks! I have release 1.0.4 containing your pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sdoward @sockeqwe