rapidjson: Add version 1.2.0-2022-03-09 #29869
Conversation
|
Hi @haralmha! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers = ['haralmha']If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame rapidjsonThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
|
can you bump Tencent/rapidjson#1006 again... maybe it's better to move away from rapidjson if they don't do releases. |
|
Holding off on the merge to get another opinion on this approach. |
Not sure how I missed this when I added my comment and approval. |
There was a problem hiding this comment.
Based on some slack feedback, IF this is the way going forward, @sethrj suggested a different naming scheme for the version (e.g., 2022-03-09 or master-2022-03-09) so it is more indicative of what is going on.
In that case, it would be good -- if there are no strong objections -- to also changing the name of the August 13th version as well.
|
I think the [latest known version]-[date] scheme is fine, so that when they finally tag a new release, our versions are ordered correctly. |
I won't stand in the way then. |
Rapidjson was constrained due to a bug (see spack#29889) , but newer (although untagged) versions of rapidjson have since been added to spack (spack#29869). Tested the build of py-awkward with the latest, works fine.
Rapidjson was constrained due to a bug (see spack#29889) , but newer (although untagged) versions of rapidjson have since been added to spack (spack#29869). Tested the build of py-awkward with the latest, works fine.
Includes PR Tencent/rapidjson#1940 which fixes Tencent/rapidjson#1924 causing errors for newer compilers on centos