[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example of .flex-wrap and -reverse #37279

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

stollr
Copy link
Contributor
@stollr stollr commented Oct 10, 2022

Description

Added numbers to the labels in the example of .flex-wrap and .flex-wrap-reverse to make it more clear what happens and how .flex-wrap-reverse works.

Motivation & Context

The current example of .flex-wrap and .flex-wrap-reverse does not really show the difference between those two utilities, because every item is labelled 'Flex item'.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Notice

If you like this PR I'd be happy if you would merge it or label it with hacktoberfest-accepted. Thanks in advance.

Live preview

Copy link
Member
@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to add those numbers to understand what happens with .flex-wrap-reverse. @mdo thoughts?

site/content/docs/5.2/utilities/flex.md Outdated Show resolved Hide resolved
The current example of `.flex-wrap` and `.flex-wrap-reverse` does not really show the difference between those two utilities, because every item is labelled 'Flex item'.

With the added numbers it is more clear what happens and how `.flex-wrap-reverse` works.
@mdo mdo merged commit 7a2f7b0 into twbs:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants