[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(website): swizzle 404 page with editor-like squiggle #7731

Merged
merged 6 commits into from
Oct 22, 2023
Merged

chore(website): swizzle 404 page with editor-like squiggle #7731

merged 6 commits into from
Oct 22, 2023

Conversation

JoshuaKGoldberg
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg commented Oct 8, 2023 •
edited

PR Checklist

Overview

Adds a 404 page somewhat like the one on learningtypescript.com/404.

Screenshot of a light mode 404 page saying '/wat' is not defined. The pathname has a red squiggly below it and '$npx eslint .' above it.

Screenshot of a dark mode 404 page saying '/blog/much-longer-title-split-across-lines' is not defined. The pathname has a red squiggly below it and '$npx eslint .' above it.

The squiggle asset is similar to the one I use on joshuakgoldberg.com.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link
netlify bot commented Oct 8, 2023 •
edited

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 452ea1a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65354e868459f9000779937d
😎 Deploy Preview https://deploy-preview-7731--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link
nx-cloud bot commented Oct 8, 2023 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 452ea1a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 from NxCloud.

Josh-Cena
Josh-Cena approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member
@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 804906d into typescript-eslint:main Oct 22, 2023
47 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the cute-404-page branch October 22, 2023 18:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Make a fun 404 page
3 participants
@JoshuaKGoldberg @bradzacher @Josh-Cena