feat(eslint-plugin): [no-array-delete] add new rule #8067
Conversation
|
Thanks for the PR, @StyleShit! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
not sure why the CI is failing. doesn't seem to be related to this PR 🤷 |
|
Yeah the CI failures are fixed on |
| if (node.argument.type !== AST_NODE_TYPES.MemberExpression) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
[Cleanup] I can see why this code helps - node.argument loses its type refinement (narrowing) inside this closure. But it's a duplicate statement that shouldn't be necessary.
I think a cleaner approach would be to store node.argument in a variable. Then we wouldn't have to worry about its type being misunderstood by TypeScript later on.
const { argument } = node;
if (argument.type !== AST_NODE_TYPES.MemberExpression) {
return;
}| if (node.argument.type !== AST_NODE_TYPES.MemberExpression) { | |
| return null; | |
| } |
Aside: I haven't looked deeply into microsoft/TypeScript#56908 to see whether it would apply to a property of a parameter.
There was a problem hiding this comment.
I actually tried it and it didn't work for some reason. now it works 😅
TS is afraid of you
Closes #4432