[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript-estree): remove unnecessary old snapshots #8198

Conversation

auvred
Copy link
Member
@auvred auvred commented Jan 6, 2024

PR Checklist

Overview

It looks like d50942c was lost in the v6 merge


Removing './tests/ast-alignment/spec\\.ts$' and './tests/[^/]+\\.test\\.ts$' test include regexes, since these files were deleted in https://github.com/typescript-eslint/typescript-eslint/commit/fb799e7a8.patch

 delete mode 100644 packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts
 delete mode 100644 packages/typescript-estree/tests/ast-alignment/parse.ts
 delete mode 100644 packages/typescript-estree/tests/ast-alignment/spec.ts
 delete mode 100644 packages/typescript-estree/tests/ast-alignment/utils.ts
 delete mode 100644 packages/typescript-estree/tests/ast-fixtures.test.ts

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link
netlify bot commented Jan 6, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3face06
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/659926881c7f4e0008abca1d
😎 Deploy Preview https://deploy-preview-8198--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@auvred auvred changed the title Chore/ts estree remove unnecessary old snapshots chore(typescript-estree): remove unnecessary old snapshots Jan 6, 2024
@auvred auvred mentioned this pull request Jan 6, 2024
26 tasks
@bradzacher
Copy link
Member

The GH app breaks on this PR so I can't actually stamp it... But the idea is sound.

Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁 ridiculous. I love it. This is going to do wonders for your repo contribution stats.

Screenshot of the pull request's +1 -420,967 diff count

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 635bb1f into typescript-eslint:main Jan 8, 2024
58 of 61 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants