[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link version in website header to GitHub release #8236

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

FloEdelmann
Copy link
Contributor
@FloEdelmann FloEdelmann commented Jan 10, 2024

(I did not follow the PR template for such a small change, I hope that's okay)

I already tried multiple times to read the current release notes by clicking on the version in the website header, so I'm proposing to actually make that a link now.

Before

Screenshot of the website header, with the version highlighted

After

Screenshot of the website header, with the version now rendered as a link

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @FloEdelmann!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link
netlify bot commented Jan 10, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a22c1bc
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/659fea4fc47f37000868a1ee
😎 Deploy Preview https://deploy-preview-8236--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@FloEdelmann FloEdelmann changed the title Link version in website header to GitHub release docs: link version in website header to GitHub release Jan 10, 2024
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Great call - this is definitely a good feature add, bordering on bugfix 😄. And I love that this also switches from manual HTML to a native Docusaurus feature (link). Thanks!

Will Ferrel as Mugatu in Zoolander saying "dear god it's beautiful"

@JoshuaKGoldberg JoshuaKGoldberg merged commit 96ffd24 into typescript-eslint:main Jan 11, 2024
56 of 57 checks passed
@FloEdelmann FloEdelmann deleted the patch-1 branch January 12, 2024 07:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants