[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention rule scripts under Local Development #9258

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Also removes the old check-configs and check-docs scripts, since they now only forward to a couple of *.test.* files in packages/eslint-plugin.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link
netlify bot commented Jun 4, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c357649
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665f2210debe1d000856f88b
😎 Deploy Preview https://deploy-preview-9258--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team June 5, 2024 15:07
Copy link
Member
@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval One team member has approved this PR; a second should be enough to merge it label Jun 7, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 629035f into typescript-eslint:main Jun 8, 2024
67 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the rule-dev-docs branch June 8, 2024 13:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval One team member has approved this PR; a second should be enough to merge it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: explain how to deal with check-configs and check-docs scripts
2 participants