[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(readme): refactor badges and readme homepage #427

Merged
merged 12 commits into from
Dec 14, 2022
Merged

refactor(readme): refactor badges and readme homepage #427

merged 12 commits into from
Dec 14, 2022

Conversation

dionysuzx
Copy link
Collaborator
@dionysuzx dionysuzx commented Dec 13, 2022 •
edited
Loading

summary

  • refactor badges to use shields.io badges, with more descriptive labels
  • remove all-contributors section (this removes our manual process of adding contributors, now it will be automatic)
  • add social badges (twitter, discord, gitpoap)
  • update project structure tree with LICENSE.md and update bridge-ui folder location

screenshots

can view updated readme here: https://github.com/taikoxyz/taiko-mono/blob/8a802357a17d28f64ab806fcdc9e7e08c5e9682b/README.md

before:
image

after:
image

@codecov
Copy link
codecov bot commented Dec 13, 2022 •
edited
Loading

Codecov Report

Merging #427 (1d4e2a5) into main (b8fbdea) will increase coverage by 0.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   65.02%   65.65%   +0.62%     
==========================================
  Files          96       99       +3     
  Lines        2605     2661      +56     
  Branches      313      313              
==========================================
+ Hits         1694     1747      +53     
  Misses        844      844              
- Partials       67       70       +3
Flag Coverage Δ *Carryforward flag
bridge-ui 100.00% <ø> (ø)
protocol 58.68% <ø> (+0.42%) ⬆️ Carriedforward from 219f6f2
relayer 69.14% <ø> (+0.80%) ⬆️
ui 100.00% <ø> (ø) Carriedforward from 219f6f2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/relayer/message/process_message.go 61.79% <0.00%> (-5.75%) ⬇️
packages/relayer/repo/event.go 72.72% <0.00%> (-2.28%) ⬇️
packages/relayer/message/processor.go 100.00% <0.00%> (ø)
packages/relayer/message/is_profitable.go 76.00% <0.00%> (ø)
packages/relayer/message/get_latest_nonce.go 72.72% <0.00%> (ø)
packages/relayer/message/wait_for_confirmations.go 80.00% <0.00%> (ø)
packages/relayer/indexer/service.go 75.26% <0.00%> (+0.26%) ⬆️
packages/relayer/cli/cli.go 61.50% <0.00%> (+0.32%) ⬆️
packages/relayer/indexer/filter_then_subscribe.go 23.52% <0.00%> (+3.77%) ⬆️
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dionysuzx dionysuzx marked this pull request as ready for review December 13, 2022 22:16
@dionysuzx dionysuzx enabled auto-merge (squash) December 13, 2022 22:23
davidtaikocha
davidtaikocha previously approved these changes Dec 14, 2022
View reviewed changes
@dionysuzx dionysuzx merged commit a81a052 into main Dec 14, 2022
@dionysuzx dionysuzx deleted the feat/refactor-badges branch December 14, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantaik dantaik dantaik approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dionysuzx @dantaik @davidtaikocha