Do not remove/insert exclusive streams #2174
Open
+141
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
355c2d7
to
88d20c4
Compare
|
Small PR, implemented one point from 1411 |
- There is no sence to remove/insert streams which are exclusive on its level of dependency tree, because they don't share badwidth with any stream. - Stop and delete exclusive stream after sending all pending data immediately. - Also some fix weight recalculation for children of exclusive stream, when it is removed. - We should check that stream with error response is active to prevent infinite loop.
88d20c4
to
6a50188
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tree, because they don't share badwidth with
any stream.