[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvement)(headless) Remove the addCollection method from EmbeddingService. #1259

Merged
merged 1 commit into from
Jun 27, 2024
Merged

(improvement)(headless) Remove the addCollection method from EmbeddingService. #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions common/src/main/java/com/tencent/supersonic/common/service/EmbeddingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
*/
public interface EmbeddingService {

void addCollection(String collectionName);

void addQuery(String collectionName, List<TextSegment> queries);

void deleteQuery(String collectionName, List<TextSegment> queries);
Expand Down
4 changes: 0 additions & 4 deletions common/src/main/java/com/tencent/supersonic/common/service/impl/EmbeddingServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ public class EmbeddingServiceImpl implements EmbeddingService {
@Autowired
private EmbeddingModel embeddingModel;

public synchronized void addCollection(String collectionName) {
embeddingStoreFactory.create(collectionName);
}

@Override
public void addQuery(String collectionName, List<TextSegment> queries) {
EmbeddingStore embeddingStore = embeddingStoreFactory.create(collectionName);
Expand Down
Loading