[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Broken Link in DQN Tutorial #372

Merged
merged 3 commits into from
May 19, 2020

Conversation

DylanCope
Copy link
Contributor

Replaced https://github.com/tensorflow/agents/blob/master/tf_agents/docs/python/tf_agents/drivers.md with https://www.tensorflow.org/agents/api_docs/python/tf_agents/drivers in the cell that defines the data collection for the replay buffer.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@DylanCope
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 9, 2020
Copy link
Member
@tfboyd tfboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the comment and then we can merge this. Thanks.

@tfboyd
Copy link
Member
tfboyd commented May 19, 2020

@DylanCope Looks like this commit (last one too I just did not notice) changed \u003ctable into <table>. I can make the change and glad you pointed it out. I like people to get the commit history in their github profile because it is fun. Let me know. There is no rush. I want you to know I am cool fixing it and I am totally cool getting this PR fixed up. I am not awesome at colabs, I am not sure why the unicode got processed.

Sorry I did not notice this the first time. I was curious why the diff was showing "everything" changed vs. just your link fix.

@DylanCope
Copy link
Contributor Author

@DylanCope Looks like this commit (last one too I just did not notice) changed \u003ctable into <table>. I can make the change and glad you pointed it out.

I had just noticed this too! I was just about to just copy across that portion of the notebook to fix it - not sure what effect it has.

I think it has changed the indentation on the file which is why it is showing up as everything having changed.

@tfboyd
Copy link
Member
tfboyd commented May 19, 2020

I would just take the original and make the small change and push that. The indention changing is kind of a pain and not desired.

@DylanCope
Copy link
Contributor Author

I went for a manual edit of the notebook file - looks much cleaner now

@tfboyd
Copy link
Member
tfboyd commented May 19, 2020

Looks great. I know this was a small change and I appreciate you making it perfect. We have a small issue with our import tools, but I will get this merged ASAP. You have my word, which is pretty good historically.

@DylanCope
Copy link
Contributor Author
DylanCope commented May 19, 2020

Cheers, and no worries its good to get it right! :)

@copybara-service copybara-service bot merged commit 84717de into tensorflow:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants