-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Broken Link in DQN Tutorial #372
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out the comment and then we can merge this. Thanks.
@DylanCope Looks like this commit (last one too I just did not notice) changed \u003ctable into Sorry I did not notice this the first time. I was curious why the diff was showing "everything" changed vs. just your link fix. |
I had just noticed this too! I was just about to just copy across that portion of the notebook to fix it - not sure what effect it has. I think it has changed the indentation on the file which is why it is showing up as everything having changed. |
I would just take the original and make the small change and push that. The indention changing is kind of a pain and not desired. |
I went for a manual edit of the notebook file - looks much cleaner now |
Looks great. I know this was a small change and I appreciate you making it perfect. We have a small issue with our import tools, but I will get this merged ASAP. You have my word, which is pretty good historically. |
Cheers, and no worries its good to get it right! :) |
Replaced
https://github.com/tensorflow/agents/blob/master/tf_agents/docs/python/tf_agents/drivers.md
withhttps://www.tensorflow.org/agents/api_docs/python/tf_agents/drivers
in the cell that defines the data collection for the replay buffer.