[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple fixes to CRAN check results in R package #697

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

terrytangyuan
Copy link
Member

Fixes #696.

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Copy link
Member
@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@terrytangyuan
Copy link
Member Author

@yongtang Is "The job exceeded the maximum time limit for jobs, and has been terminated" fine? We are not changing any Python/C++ code in this PR anyways.

@yongtang
Copy link
Member

@terrytangyuan I think we should be fine as long as Kokoro CI pass.

@terrytangyuan terrytangyuan merged commit 7a87370 into tensorflow:master Dec 18, 2019
@terrytangyuan terrytangyuan deleted the fix-cran-checks branch December 18, 2019 17:33
i-ony pushed a commit to i-ony/io that referenced this pull request Feb 8, 2021
* A couple fixes to CRAN check results in R package

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>

* Fix invalid URL and rebuild docs

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve R package check warnings and re-submit to CRAN
2 participants