[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple output models #223

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Add support for multiple output models #223

merged 3 commits into from
Dec 1, 2022

Conversation

casassg
Copy link
Member
@casassg casassg commented Aug 17, 2022

Extend annotate_eval_result_metrics to support models which have multiple outputs.

If a model has multiple outputs, we namespace each metric by adding output_name.metric_name on the quantitative analysis part of the model card.

@casassg casassg marked this pull request as ready for review August 17, 2022 17:31
codesue
codesue previously approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator
@codesue codesue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! LGTM since all tests pass. Adding a new test would be ideal, but I don't want to block on that.

model_card_toolkit/utils/tfx_util.py Outdated Show resolved Hide resolved
@codesue codesue merged commit 87c0b4d into tensorflow:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codesue codesue codesue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@casassg @codesue