Make tests pytest and unittest compatible #254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This pull request enables running tests with pytest and unittest as the test runners. Previously, running tests with these runners raised the following error:
This happened because the absl flags were only being parsed when running the modules directly. With this change, flags are manually parsed and use default values if the modules aren't run directly, as is the case when using pyttest and unittest. See the absl-py flags documentation for a more detailed explanation.
How did you test this change?
pytest
Ran
pytest model_card_toolkit
. Abridged summary:unittest
Couldn't figure out the right pattern to discover all tests, so I only tested the problematic modules.
Ran
python -m unittest model_card_toolkit/core_test.py
:Ran
python -m unittest model_card_toolkit/utils/testdata/tfxtest.py
:How did you document this change?
N/A
Before submitting
Before submitting a pull request, please be sure to do the following: