-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo fixed in CODE_OF_CONDUCT.md #14175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
benoitsteiner
approved these changes
Nov 2, 2017
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…ug information. Imported from GitHub PR openxla/xla#14175 This PR assign a name to each command buffer cmd, so to help print debug information when needed. Copybara import of the project: -- aa31d0806ffb5609e3431ba04efbb595f5e26f51 by Shawn Wang <shawnw@nvidia.com>: Add name to each command buffer cmd -- 8a955660d27384d08846402e51b226048eb7dcb1 by Shawn Wang <shawnw@nvidia.com>: fix for review comments Merging this change closes #14175 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14175 from shawnwang18:shawnw/add_trace_cache_vlog 8a955660d27384d08846402e51b226048eb7dcb1 PiperOrigin-RevId: 646984261
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…ug information. Imported from GitHub PR openxla/xla#14175 This PR assign a name to each command buffer cmd, so to help print debug information when needed. Copybara import of the project: -- aa31d0806ffb5609e3431ba04efbb595f5e26f51 by Shawn Wang <shawnw@nvidia.com>: Add name to each command buffer cmd -- 8a955660d27384d08846402e51b226048eb7dcb1 by Shawn Wang <shawnw@nvidia.com>: fix for review comments Merging this change closes #14175 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14175 from shawnwang18:shawnw/add_trace_cache_vlog 8a955660d27384d08846402e51b226048eb7dcb1 PiperOrigin-RevId: 646984261
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…ug information. Imported from GitHub PR openxla/xla#14175 This PR assign a name to each command buffer cmd, so to help print debug information when needed. Copybara import of the project: -- aa31d0806ffb5609e3431ba04efbb595f5e26f51 by Shawn Wang <shawnw@nvidia.com>: Add name to each command buffer cmd -- 8a955660d27384d08846402e51b226048eb7dcb1 by Shawn Wang <shawnw@nvidia.com>: fix for review comments Merging this change closes #14175 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14175 from shawnwang18:shawnw/add_trace_cache_vlog 8a955660d27384d08846402e51b226048eb7dcb1 PiperOrigin-RevId: 646984261
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…ug information. Imported from GitHub PR openxla/xla#14175 This PR assign a name to each command buffer cmd, so to help print debug information when needed. Copybara import of the project: -- aa31d0806ffb5609e3431ba04efbb595f5e26f51 by Shawn Wang <shawnw@nvidia.com>: Add name to each command buffer cmd -- 8a955660d27384d08846402e51b226048eb7dcb1 by Shawn Wang <shawnw@nvidia.com>: fix for review comments Merging this change closes #14175 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14175 from shawnwang18:shawnw/add_trace_cache_vlog 8a955660d27384d08846402e51b226048eb7dcb1 PiperOrigin-RevId: 646984261
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…ug information. Imported from GitHub PR openxla/xla#14175 This PR assign a name to each command buffer cmd, so to help print debug information when needed. Copybara import of the project: -- aa31d0806ffb5609e3431ba04efbb595f5e26f51 by Shawn Wang <shawnw@nvidia.com>: Add name to each command buffer cmd -- 8a955660d27384d08846402e51b226048eb7dcb1 by Shawn Wang <shawnw@nvidia.com>: fix for review comments Merging this change closes #14175 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14175 from shawnwang18:shawnw/add_trace_cache_vlog 8a955660d27384d08846402e51b226048eb7dcb1 PiperOrigin-RevId: 646984261
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…ug information. Imported from GitHub PR openxla/xla#14175 This PR assign a name to each command buffer cmd, so to help print debug information when needed. Copybara import of the project: -- aa31d0806ffb5609e3431ba04efbb595f5e26f51 by Shawn Wang <shawnw@nvidia.com>: Add name to each command buffer cmd -- 8a955660d27384d08846402e51b226048eb7dcb1 by Shawn Wang <shawnw@nvidia.com>: fix for review comments Merging this change closes #14175 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14175 from shawnwang18:shawnw/add_trace_cache_vlog 8a955660d27384d08846402e51b226048eb7dcb1 PiperOrigin-RevId: 646984261
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…ug information. Imported from GitHub PR openxla/xla#14175 This PR assign a name to each command buffer cmd, so to help print debug information when needed. Copybara import of the project: -- aa31d0806ffb5609e3431ba04efbb595f5e26f51 by Shawn Wang <shawnw@nvidia.com>: Add name to each command buffer cmd -- 8a955660d27384d08846402e51b226048eb7dcb1 by Shawn Wang <shawnw@nvidia.com>: fix for review comments Merging this change closes #14175 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14175 from shawnwang18:shawnw/add_trace_cache_vlog 8a955660d27384d08846402e51b226048eb7dcb1 PiperOrigin-RevId: 646984261
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
…ug information. Imported from GitHub PR openxla/xla#14175 This PR assign a name to each command buffer cmd, so to help print debug information when needed. Copybara import of the project: -- aa31d0806ffb5609e3431ba04efbb595f5e26f51 by Shawn Wang <shawnw@nvidia.com>: Add name to each command buffer cmd -- 8a955660d27384d08846402e51b226048eb7dcb1 by Shawn Wang <shawnw@nvidia.com>: fix for review comments Merging this change closes #14175 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14175 from shawnwang18:shawnw/add_trace_cache_vlog 8a955660d27384d08846402e51b226048eb7dcb1 PiperOrigin-RevId: 646984261
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
…ug information. Imported from GitHub PR openxla/xla#14175 This PR assign a name to each command buffer cmd, so to help print debug information when needed. Copybara import of the project: -- aa31d0806ffb5609e3431ba04efbb595f5e26f51 by Shawn Wang <shawnw@nvidia.com>: Add name to each command buffer cmd -- 8a955660d27384d08846402e51b226048eb7dcb1 by Shawn Wang <shawnw@nvidia.com>: fix for review comments Merging this change closes #14175 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14175 from shawnwang18:shawnw/add_trace_cache_vlog 8a955660d27384d08846402e51b226048eb7dcb1 PiperOrigin-RevId: 646984261
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
…ug information. Imported from GitHub PR openxla/xla#14175 This PR assign a name to each command buffer cmd, so to help print debug information when needed. Copybara import of the project: -- aa31d0806ffb5609e3431ba04efbb595f5e26f51 by Shawn Wang <shawnw@nvidia.com>: Add name to each command buffer cmd -- 8a955660d27384d08846402e51b226048eb7dcb1 by Shawn Wang <shawnw@nvidia.com>: fix for review comments Merging this change closes #14175 Reverts 1c218c7 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14175 from shawnwang18:shawnw/add_trace_cache_vlog 8a955660d27384d08846402e51b226048eb7dcb1 PiperOrigin-RevId: 646984261
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
…ug information. Imported from GitHub PR openxla/xla#14175 This PR assign a name to each command buffer cmd, so to help print debug information when needed. Copybara import of the project: -- aa31d0806ffb5609e3431ba04efbb595f5e26f51 by Shawn Wang <shawnw@nvidia.com>: Add name to each command buffer cmd -- 8a955660d27384d08846402e51b226048eb7dcb1 by Shawn Wang <shawnw@nvidia.com>: fix for review comments Merging this change closes #14175 PiperOrigin-RevId: 647426567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spelling of behaviour is a non-American variant. For consistency, consider replacing it with the
American English spelling.
the word
behaviour
in located at line 16 asbehavior
, so why typing it in two ways?