[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Haiku support #13569

Merged
merged 9 commits into from
Nov 5, 2017
Merged

Initial Haiku support #13569

merged 9 commits into from
Nov 5, 2017

Conversation

extrowerk
Copy link

No description provided.

@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@extrowerk
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 8, 2017
@caisq caisq requested a review from mrry October 9, 2017 00:23
@caisq caisq added the awaiting review Pull request awaiting review label Oct 9, 2017
@caisq caisq requested a review from gunan October 9, 2017 13:25
@gunan
Copy link
Contributor
gunan commented Oct 9, 2017

@martinwicke WDYT?

@martinwicke
Copy link
Member

Instead of making PIC depend on Haiku directly, can you add a generic option to turn off PIC, and make haiku use that option?

Since this is limited to PIC and some error codes (for which we already have FreeBSD exceptions) I'm fine with this change otherwise.

@extrowerk
Copy link
Author

@martinwicke : Sadly currently i have no idea how to create a variable what can propagate through the cmake files, but i'll look into it. Have you got an example maybe?

@martinwicke
Copy link
Member
martinwicke commented Oct 10, 2017 via email

@extrowerk
Copy link
Author

thanks! Will try at weekend!

@extrowerk extrowerk force-pushed the haiku_support branch 2 times, most recently from 27d2b78 to b06c742 Compare October 22, 2017 08:52
@extrowerk
Copy link
Author

@martinwicke : Tried to do it as good as possible,but i have not too much experiences with cmake.Can you look into it please?

Thanks!

@extrowerk
Implement PIE switch on top level
f254464 
and PIE switch for external modules
@gunan
Copy link
Contributor
gunan commented Oct 23, 2017

There seems to be a merge conflict. could you rebase your change on top of master?

@extrowerk
Copy link
Author

@gunan : conflict solved.

@gunan
Copy link
Contributor
gunan commented Oct 23, 2017

Jenkins, test this please.

@gunan gunan added the kokoro:force-run Tests on submitted change label Oct 23, 2017
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 23, 2017
@extrowerk
Copy link
Author

Checks looks ok 👍

@extrowerk
Copy link
Author

Any news here?

@gunan gunan merged commit 98f121b into tensorflow:master Nov 5, 2017
@nehaljwani
Copy link
Contributor

Hi @extrowerk !

Could you please share the reason as to why you disabled PIC for Haiku builds? Just curious!

@extrowerk
Copy link
Author

@nehaljwani i disabled PIE, not PIC.
I cannot explain you correctly, i don't know much about technologies behind the curtain in Haiku, but it is required, without it it results just linking problems.

copybara-service bot pushed a commit that referenced this pull request Jun 11, 2024
@sergachev @tensorflower-gardener
PR #13569: [GPU] Add on-disk per-kernel compilation cache.
3f7b1a8 
Imported from GitHub PR openxla/xla#13569

Copybara import of the project:

--
6c366cf77a749f10c9e23a52e4ee7b16359baaf8 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Let constants be emitted into a separate LLVM module.

--
a164cd1214fecd70e6538c8995d0a7318264a439 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Add on-disk per-kernel compilation cache.

--
7808613eb73dda37f15b69a82ca0617613cd98ce by Ilia Sergachev <isergachev@nvidia.com>:

Skip kernel cache tests when linking is not available.

--
89694a031c441605f45b36fc606a1b6e6a351492 by Ilia Sergachev <isergachev@nvidia.com>:

Address feedback

--
cf8ddb3f41413d4fb8c7440cf3b10d2100a89bf4 by Ilia Sergachev <isergachev@nvidia.com>:

Remove static keyword

Merging this change closes #13569

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13569 from openxla:disk_kernel_cache cf8ddb3f41413d4fb8c7440cf3b10d2100a89bf4
PiperOrigin-RevId: 642202829
@copybara-service copybara-service bot mentioned this pull request Jun 11, 2024
Draft
copybara-service bot pushed a commit that referenced this pull request Jun 11, 2024
@sergachev @tensorflower-gardener
PR #13569: [GPU] Add on-disk per-kernel compilation cache.
a81da4e 
Imported from GitHub PR openxla/xla#13569

Copybara import of the project:

--
6c366cf77a749f10c9e23a52e4ee7b16359baaf8 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Let constants be emitted into a separate LLVM module.

--
a164cd1214fecd70e6538c8995d0a7318264a439 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Add on-disk per-kernel compilation cache.

--
7808613eb73dda37f15b69a82ca0617613cd98ce by Ilia Sergachev <isergachev@nvidia.com>:

Skip kernel cache tests when linking is not available.

--
89694a031c441605f45b36fc606a1b6e6a351492 by Ilia Sergachev <isergachev@nvidia.com>:

Address feedback

--
cf8ddb3f41413d4fb8c7440cf3b10d2100a89bf4 by Ilia Sergachev <isergachev@nvidia.com>:

Remove static keyword

Merging this change closes #13569

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13569 from openxla:disk_kernel_cache cf8ddb3f41413d4fb8c7440cf3b10d2100a89bf4
PiperOrigin-RevId: 642202829
copybara-service bot pushed a commit that referenced this pull request Jun 12, 2024
@sergachev @tensorflower-gardener
PR #13569: [GPU] Add on-disk per-kernel compilation cache.
5a7ef3c 
Imported from GitHub PR openxla/xla#13569

Copybara import of the project:

--
6ec3e04a2982ceecadc17d51adb31f61cea70067 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Let constants be emitted into a separate LLVM module.

--
e4d5869895751dbea1f4c8e3af9c20e6963ba8ee by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Add on-disk per-kernel compilation cache.

--
1dbf7fe8bf11cd15f8138eae7dc2d71c4d945fdd by Ilia Sergachev <isergachev@nvidia.com>:

Skip kernel cache tests when linking is not available.

--
7d07531680954257a4c8a968969c9bd72c19e4ca by Ilia Sergachev <isergachev@nvidia.com>:

Address feedback

--
363caaf6c299c4a0568f590e7118fcfcb675f110 by Ilia Sergachev <isergachev@nvidia.com>:

Remove static keyword

Merging this change closes #13569

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13569 from openxla:disk_kernel_cache 363caaf6c299c4a0568f590e7118fcfcb675f110
PiperOrigin-RevId: 642196399
@copybara-service copybara-service bot mentioned this pull request Jun 12, 2024
Draft
copybara-service bot pushed a commit that referenced this pull request Jun 12, 2024
@sergachev @tensorflower-gardener
PR #13569: [GPU] Add on-disk per-kernel compilation cache.
43ab4de 
Imported from GitHub PR openxla/xla#13569

Copybara import of the project:

--
6c366cf77a749f10c9e23a52e4ee7b16359baaf8 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Let constants be emitted into a separate LLVM module.

--
a164cd1214fecd70e6538c8995d0a7318264a439 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Add on-disk per-kernel compilation cache.

--
7808613eb73dda37f15b69a82ca0617613cd98ce by Ilia Sergachev <isergachev@nvidia.com>:

Skip kernel cache tests when linking is not available.

--
89694a031c441605f45b36fc606a1b6e6a351492 by Ilia Sergachev <isergachev@nvidia.com>:

Address feedback

--
cf8ddb3f41413d4fb8c7440cf3b10d2100a89bf4 by Ilia Sergachev <isergachev@nvidia.com>:

Remove static keyword

Merging this change closes #13569

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13569 from openxla:disk_kernel_cache cf8ddb3f41413d4fb8c7440cf3b10d2100a89bf4
PiperOrigin-RevId: 642202829
copybara-service bot pushed a commit that referenced this pull request Jun 12, 2024
@sergachev @tensorflower-gardener
PR #13569: [GPU] Add on-disk per-kernel compilation cache.
ef30e42 
Imported from GitHub PR openxla/xla#13569

Copybara import of the project:

--
d19e603b45c12b5ecb03897008c39fb3a6d545b5 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Let constants be emitted into a separate LLVM module.

--
39cababa22e013abc9dbec361c07366adc76c14c by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Add on-disk per-kernel compilation cache.

--
627acbfe72b0b8729164a4a4c7d7ff0d4c921280 by Ilia Sergachev <isergachev@nvidia.com>:

Skip kernel cache tests when linking is not available.

--
88f491f031da41ec6077ddef57969dbc63b1e455 by Ilia Sergachev <isergachev@nvidia.com>:

Address feedback

--
913f67a870babab3a833f7847ca215bd128b9803 by Ilia Sergachev <isergachev@nvidia.com>:

Remove static keyword

Merging this change closes #13569

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13569 from openxla:disk_kernel_cache 913f67a870babab3a833f7847ca215bd128b9803
PiperOrigin-RevId: 642196399
copybara-service bot pushed a commit that referenced this pull request Jun 12, 2024
@sergachev @tensorflower-gardener
PR #13569: [GPU] Add on-disk per-kernel compilation cache.
1c6f896 
Imported from GitHub PR openxla/xla#13569

Copybara import of the project:

--
d19e603b45c12b5ecb03897008c39fb3a6d545b5 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Let constants be emitted into a separate LLVM module.

--
39cababa22e013abc9dbec361c07366adc76c14c by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Add on-disk per-kernel compilation cache.

--
627acbfe72b0b8729164a4a4c7d7ff0d4c921280 by Ilia Sergachev <isergachev@nvidia.com>:

Skip kernel cache tests when linking is not available.

--
88f491f031da41ec6077ddef57969dbc63b1e455 by Ilia Sergachev <isergachev@nvidia.com>:

Address feedback

--
913f67a870babab3a833f7847ca215bd128b9803 by Ilia Sergachev <isergachev@nvidia.com>:

Remove static keyword

Merging this change closes #13569

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13569 from openxla:disk_kernel_cache 913f67a870babab3a833f7847ca215bd128b9803
PiperOrigin-RevId: 642591328
@copybara-service copybara-service bot mentioned this pull request Jun 12, 2024
Merged
copybara-service bot pushed a commit that referenced this pull request Jun 12, 2024
@sergachev @tensorflower-gardener
PR #13569: [GPU] Add on-disk per-kernel compilation cache.
4348bc5 
Imported from GitHub PR openxla/xla#13569

Copybara import of the project:

--
d19e603b45c12b5ecb03897008c39fb3a6d545b5 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Let constants be emitted into a separate LLVM module.

--
39cababa22e013abc9dbec361c07366adc76c14c by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Add on-disk per-kernel compilation cache.

--
627acbfe72b0b8729164a4a4c7d7ff0d4c921280 by Ilia Sergachev <isergachev@nvidia.com>:

Skip kernel cache tests when linking is not available.

--
88f491f031da41ec6077ddef57969dbc63b1e455 by Ilia Sergachev <isergachev@nvidia.com>:

Address feedback

--
913f67a870babab3a833f7847ca215bd128b9803 by Ilia Sergachev <isergachev@nvidia.com>:

Remove static keyword

Merging this change closes #13569

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13569 from openxla:disk_kernel_cache 913f67a870babab3a833f7847ca215bd128b9803
PiperOrigin-RevId: 642196399
copybara-service bot pushed a commit that referenced this pull request Jun 12, 2024
@sergachev @tensorflower-gardener
PR #13569: [GPU] Add on-disk per-kernel compilation cache.
7912f4e 
Imported from GitHub PR openxla/xla#13569

Copybara import of the project:

--
d19e603b45c12b5ecb03897008c39fb3a6d545b5 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Let constants be emitted into a separate LLVM module.

--
39cababa22e013abc9dbec361c07366adc76c14c by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Add on-disk per-kernel compilation cache.

--
627acbfe72b0b8729164a4a4c7d7ff0d4c921280 by Ilia Sergachev <isergachev@nvidia.com>:

Skip kernel cache tests when linking is not available.

--
88f491f031da41ec6077ddef57969dbc63b1e455 by Ilia Sergachev <isergachev@nvidia.com>:

Address feedback

--
913f67a870babab3a833f7847ca215bd128b9803 by Ilia Sergachev <isergachev@nvidia.com>:

Remove static keyword

Merging this change closes #13569

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13569 from openxla:disk_kernel_cache 913f67a870babab3a833f7847ca215bd128b9803
PiperOrigin-RevId: 642591328
copybara-service bot pushed a commit that referenced this pull request Jun 12, 2024
@sergachev @tensorflower-gardener
PR #13569: [GPU] Add on-disk per-kernel compilation cache.
d12a006 
Imported from GitHub PR openxla/xla#13569

Copybara import of the project:

--
d19e603b45c12b5ecb03897008c39fb3a6d545b5 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Let constants be emitted into a separate LLVM module.

--
39cababa22e013abc9dbec361c07366adc76c14c by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Add on-disk per-kernel compilation cache.

--
627acbfe72b0b8729164a4a4c7d7ff0d4c921280 by Ilia Sergachev <isergachev@nvidia.com>:

Skip kernel cache tests when linking is not available.

--
88f491f031da41ec6077ddef57969dbc63b1e455 by Ilia Sergachev <isergachev@nvidia.com>:

Address feedback

--
913f67a870babab3a833f7847ca215bd128b9803 by Ilia Sergachev <isergachev@nvidia.com>:

Remove static keyword

Merging this change closes #13569

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#13569 from openxla:disk_kernel_cache 913f67a870babab3a833f7847ca215bd128b9803
PiperOrigin-RevId: 642196399
copybara-service bot pushed a commit that referenced this pull request Jun 12, 2024
@sergachev @tensorflower-gardener
PR #13569: [GPU] Add on-disk per-kernel compilation cache.
1be97ef 
Imported from GitHub PR openxla/xla#13569

Copybara import of the project:

--
d19e603b45c12b5ecb03897008c39fb3a6d545b5 by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Let constants be emitted into a separate LLVM module.

--
39cababa22e013abc9dbec361c07366adc76c14c by Ilia Sergachev <isergachev@nvidia.com>:

[GPU] Add on-disk per-kernel compilation cache.

--
627acbfe72b0b8729164a4a4c7d7ff0d4c921280 by Ilia Sergachev <isergachev@nvidia.com>:

Skip kernel cache tests when linking is not available.

--
88f491f031da41ec6077ddef57969dbc63b1e455 by Ilia Sergachev <isergachev@nvidia.com>:

Address feedback

--
913f67a870babab3a833f7847ca215bd128b9803 by Ilia Sergachev <isergachev@nvidia.com>:

Remove static keyword

Merging this change closes #13569

PiperOrigin-RevId: 642604067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunan gunan gunan approved these changes

@mrry mrry Awaiting requested review from mrry

Assignees

@mrry mrry

Labels
awaiting review Pull request awaiting review cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@extrowerk @tensorflow-jenkins @googlebot @gunan @martinwicke @nehaljwani @mrry @caisq @kokoro-team