[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign compare warning fixes batch 1 #40371

Conversation

tg-at-google
Copy link
Contributor

warning ids: [ 28, 29, 30, 31, 32, 33, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 50, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 94, 95, 96, 97, 98, 99 100, 101, 102, 103 ]

@mihaimaruseac

@google-ml-butler google-ml-butler bot added the size:XL CL Change Size:Extra Large label Jun 11, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

Copy link
Contributor
@joker-eph joker-eph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fairly inconsistent, and quite noisy. What is the purpose of forcing this to be explicit everywhere?

@gbaned gbaned self-assigned this Jun 11, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jun 11, 2020
@mihaimaruseac mihaimaruseac self-requested a review June 11, 2020 16:01
@tg-at-google tg-at-google force-pushed the sign-compare-warning-fixes-batch-1 branch from a755b11 to 5cbd0bc Compare June 11, 2020 16:23
Copy link
Contributor Author
@tg-at-google tg-at-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator
@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll let Mehdi give the final approval

joker-eph
joker-eph previously approved these changes Jun 16, 2020
Copy link
Contributor
@joker-eph joker-eph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jun 16, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 16, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 16, 2020
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Jun 17, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Jun 17, 2020
@tg-at-google
Copy link
Contributor Author

I changed quantization_config.cc because it failed the build.

@joker-eph

@gbaned gbaned requested a review from joker-eph June 17, 2020 07:00
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jun 17, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 17, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 17, 2020
@tg-at-google
Copy link
Contributor Author

@joker-eph

@tensorflow-copybara tensorflow-copybara merged commit 9eed8b3 into tensorflow:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XL CL Change Size:Extra Large
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

7 participants