[NVIDIA TF:XLA:JAX] Add NVIDIA as a Trusted Partner and assign reviewers #56704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjannaty
commented
Jul 7, 2022
| assignees.push('cheshire', 'cforster', 'reedwm', 'csigg'); | ||
| } | ||
| if (title.toLowerCase().includes("tf")) { | ||
| assignees.push('rohanj', 'bfontain', 'penporn'); |
There was a problem hiding this comment.
Could you please check the Googler ldaps? Some appear to have different usernames linked to their github account.
There was a problem hiding this comment.
GitHub usernames: hawkinsp, cheshire, gcforster, reedwm, chsigg, rohan100jain, bfontain, penpornk
Can you please update accordingly?
There was a problem hiding this comment.
Thank you for confirming, done!
yashk2810
reviewed
Jul 8, 2022
| assignees = apple_silicon_assignees; | ||
| if (title && title.toLowerCase().includes("nvidia") && domain.includes("nvidia.com")) { | ||
| if (title.toLowerCase().includes("jax")) { | ||
| assignees.push('hawkinsp'); |
There was a problem hiding this comment.
Please add yashk2810 for jax too :)
skye
reviewed
Jul 8, 2022
| assignees = apple_silicon_assignees; | ||
| if (title && title.toLowerCase().includes("nvidia") && domain.includes("nvidia.com")) { | ||
| if (title.toLowerCase().includes("jax")) { | ||
| assignees.push('hawkinsp', 'yashk2810'); |
There was a problem hiding this comment.
I can also help out here, please add 'skye'
There was a problem hiding this comment.
Great, added! Thank you for offering!
…in check to prevent accidental cross-partner triggering of assignments.
learning-to-play
approved these changes
Jul 11, 2022
sampathweb
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NVIDIA as a Trusted Partner and assign reviewers. Also add a domain check to prevent accidental cross-partner triggering of assignments.
Per-component designated reviewers:
The assignment logic retains the possibility of dispatching changes to more than one component, e.g. [NVIDIA TF XLA].
cc: @hawkinsp @yashk2810 @cheshire @gcforster @reedwm @chsigg @rohan100jain @bfontain @penpornk @skye