Update README.md - clarification #6427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I initially followed instructions - and got more errors. The build all script should be first call to action for newbies.
|
Can one of the admins verify this patch? |
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
…fig.py instead of using `glob()` Imported from GitHub PR openxla/xla#6427 We know the exact location and don't need to glob() here. The issue with glob is that it can be slow, in particular when re-running the configure script after building with Bazel: the glob will process tens of GB of build directories! Copybara import of the project: -- d0ccab91c465871c6c87f9bcf1746cbd5da47967 by Mehdi Amini <mamini@nvidia.com>: Fix configure.py to more directly specify the find_cuda_config.py instead of using `glob()` We know the exact location and don't need to glob() here. The issue with glob is that it can be slow, in particular when re-running the configure script after building with Bazel: the glob will process tens of GB of build directories! Merging this change closes #6427 PiperOrigin-RevId: 575020900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially followed instructions - and got more errors.
The build all script should be first call to action for newbies.