Make the CI at least build unsupported GPU test targets #67325
Merged
+32
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
612b9ac
to
7533846
Compare
c832c10
to
324f01c
Compare
We had issues in the past where PRs were changing code that can't be tested in the GitHub CI because we don't have the required GPU models available there. Building those tests would have been enough to find those issues earlier. So this make the OpenXLA also build tests that it can't run (due to lack of available GPU types). PiperOrigin-RevId: 647195625
324f01c
to
ab3f907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the CI at least build unsupported GPU test targets
We had issues in the past where PRs were changing code that can't be tested in the GitHub CI because we don't have the required GPU models available there. Building
those tests would have been enough to find those issues earlier.
So this make the OpenXLA also build tests that it can't run (due to lack of available
GPU types).