[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDNN][BugFix] Fix dtype utility function for F16 AVX2 DL extension #69087

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akhilgoe
Copy link
Contributor
@akhilgoe akhilgoe commented Jun 3, 2024

Intel's Efficiency cores do not support AVX512 instructions. However, some of them do support lower precisions (BF16/FP16) by converting to and from FP32. Due to the lack of Byte and Word instruction set support, the current condition check always returns False, even on supporting E-cores. This PR fixes the condition to correctly return True on all compatible hardware.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jun 3, 2024
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Jun 4, 2024
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jun 4, 2024
@gbaned gbaned requested a review from penpornk June 4, 2024 07:00
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Pull request awaiting review comp:core issues related to core part of tensorflow size:S CL Change Size: Small
Projects
PR Queue
  
Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

2 participants