Increase default safety of Keras tar extraction #69752
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Python 3.12 adds increased safety options for tarfile.extractall() but are disabled by default. This enables an tarfile extraction filter. https://docs.python.org/3/library/tarfile.html#tarfile-extraction-filter
|
I think this might need to be made on the keras org repo, instead of here |
I think you might be right, based on this: The big thing to me is that even if the code is on the way out (for the last 3 years?), it's still there and still gets flagged by certain security scans as an unsafe method of extracting .tar files. I'm looking at some of the demo notebooks, and unless I'm misunderstanding how the imports work, they use the Keras functions in this library, not the Keras org repo functions. |
|
So, there are 2 Keras(es): one is Keras 3 that should be multi-framework, write code once and change an environment variable and now you use PyTorch as backend, change it again and now you use JAX. The other one is Keras as it was inside TF between TF 2.0 and TF 2.. The latter is what is still in the repo, but it should be taken as a frozen copy. All new updates should occur on the newer multi-framework Keras instead. |
Python 3.12 adds increased safety options for tarfile.extractall() but are disabled by default.
This enables an tarfile extraction filter if using Python 3.12 or higher.
The default for tarfile.extractall() will be set to 'data' in Python 3.14.
Applications and system integrators may wish to change extraction_filter of the TarFile class itself to set a global default. When using a function, they will generally want to wrap it in staticmethod() to prevent injection of a self argument.
References:
https://docs.python.org/3/library/tarfile.html#tarfile-extraction-filter
PEP 706 – Filter for tarfile.extractall