[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOSA] Separate left shifting in SQUARED_DIFFERENCE to avoid precision loss #61991

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[TOSA] Separate left shifting in SQUARED_DIFFERENCE to avoid precision loss #61991

wants to merge 2 commits into from

Conversation

Tessil
Copy link
Contributor
@Tessil Tessil commented Sep 27, 2023

Hi,

This PR moves the left shifting in the tfl.squared_difference TFL -> TOSA legalization in a separate tosa.rescale to avoid any precision loss which could create non bit-exact results.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Sep 27, 2023
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Sep 28, 2023
@tilakrayal tilakrayal added this to Assigned Reviewer in PR Queue via automation Sep 28, 2023
@gbaned
Copy link
Contributor
gbaned commented Oct 5, 2023

Hi @Tessil Can you please resolve conflicts? Thank you!

@gbaned gbaned added stat:awaiting response Status - Awaiting response from author and removed awaiting review Pull request awaiting review labels Oct 5, 2023
@github-actions
Copy link

This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Oct 20, 2023
@Tessil
Copy link
Contributor Author
Tessil commented Oct 20, 2023

@gbaned Done, thanks.

@google-ml-butler google-ml-butler bot removed stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author labels Oct 20, 2023
@gbaned gbaned requested a review from jpienaar November 3, 2023 09:21
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Nov 3, 2023
@gbaned
Copy link
Contributor
gbaned commented Dec 15, 2023

Hi @jpienaar Can you please review this PR ? Thank you!

1 similar comment
@gbaned
Copy link
Contributor
gbaned commented Dec 29, 2023

Hi @jpienaar Can you please review this PR ? Thank you!

@gbaned gbaned requested review from rdzhabarov and removed request for rsuderman February 9, 2024 08:22
@gbaned
Copy link
Contributor
gbaned commented Mar 8, 2024

Hi @rdzhabarov Can you please review this PR ? Thank you!

@gbaned
Copy link
Contributor
gbaned commented Apr 26, 2024

Hi @jpienaar Can you please review this PR ? Thank you!

1 similar comment
@gbaned
Copy link
Contributor
gbaned commented Jun 7, 2024

Hi @jpienaar Can you please review this PR ? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpienaar jpienaar Awaiting requested review from jpienaar

@rdzhabarov rdzhabarov Awaiting requested review from rdzhabarov

Assignees

@gbaned gbaned

Labels
awaiting review Pull request awaiting review size:S CL Change Size: Small
Projects
PR Queue
  
Assigned Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tessil @gbaned